[workspace] Deprecate the stduuid external #18610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwnimmer-tri
added
priority: low
release notes: newly deprecated
Fork it to stduuid_internal (with hidden C++ visibility) instead. Fix the new copy to actually install its license file. Adjust the new copy to be vendored and linker-hidden. Rework gsl build rule and note that gsl is soon-to-be unused. Co-authored-by: Betsy McPhail <[email protected]> Co-authored-by: Matthew Woehlke <[email protected]> Co-authored-by: Russ Tedrake <[email protected]>
jwnimmer-tri
force-pushed
the
stduuid-internal
branch
from
8a5ad64 to
fbdcd08
Compare
48 tasks
|
+@rpoyner-tri for feature review, please. (Or both reviews, if you like.) Note that some of the code in |
rpoyner-tri
added
the
status: single reviewer ok
rpoyner-tri
reviewed
Jan 18, 2023
There was a problem hiding this comment.
Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status:complete! all discussions resolved, LGTM from assignee rpoyner-tri(platform) (waiting on @jwnimmer-tri)
xuchenhan-tri
pushed a commit
to xuchenhan-tri/drake
that referenced
this pull request
Feb 3, 2023
Co-Authored-By: Betsy McPhail <[email protected]> Co-Authored-By: Matthew Woehlke <[email protected]> Co-Authored-By: Russ Tedrake <[email protected]>
marcoag
pushed a commit
to marcoag/drake
that referenced
this pull request
Feb 6, 2023
Co-Authored-By: Betsy McPhail <[email protected]> Co-Authored-By: Matthew Woehlke <[email protected]> Co-Authored-By: Russ Tedrake <[email protected]>
xuchenhan-tri
pushed a commit
to xuchenhan-tri/drake
that referenced
this pull request
Feb 6, 2023
Co-Authored-By: Betsy McPhail <[email protected]> Co-Authored-By: Matthew Woehlke <[email protected]> Co-Authored-By: Russ Tedrake <[email protected]>
marcoag
pushed a commit
to marcoag/drake
that referenced
this pull request
Mar 8, 2023
Co-Authored-By: Betsy McPhail <[email protected]> Co-Authored-By: Matthew Woehlke <[email protected]> Co-Authored-By: Russ Tedrake <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fork it to
@stduuid_internalinstead.Fix the new copy to actually install its license file.
Adjust the new copy to use a numbered version now that upstream uses tags.
Adjust the new copy to be vendored and linker-hidden.
Rework
gslbuild rule and note thatgslis soon-to-be unused.Towards #17231.
Note that Focal users will still be at ODR-risk for
gsl::span, since we don't vendor that here. It doesn't seem worth the effort since Focal support will eventually evaporate.This change is