[workspace] Deprecate the csdp external #19894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwnimmer-tri
added
priority: low
release notes: newly deprecated
48 tasks
Switch the csdp_internal C code to build using hidden visibility.
jwnimmer-tri
force-pushed
the
vendor-csdp
branch
from
a511c50 to
db8400d
Compare
jwnimmer-tri
added
the
status: single reviewer ok
|
Whoever is least exhausted with these deprecation PRs, please feel free to self-assign this one for review, too -- \CC @rpoyner-tri @xuchenhan-tri @ggould-tri @sammy-tri |
|
I can take this one +@xuchenhan-tri |
There was a problem hiding this comment.
Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status:complete! all discussions resolved, LGTM from assignee xuchenhan-tri(platform)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #17231.
This change is