[tools] Add test to flag hazardous exported symbols #20279
Conversation
jwnimmer-tri
added
priority: low
status: do not merge
status: do not review
release notes: none
jwnimmer-tri
force-pushed
the
exported-symbols-test
branch
2 times, most recently
from
b7bd8df to
a78cf1e
Compare
jwnimmer-tri
force-pushed
the
exported-symbols-test
branch
2 times, most recently
from
c9f00bb to
88ef4f1
Compare
|
+@rpoyner-tri for feature review, please. |
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: LGTM missing from assignee rpoyner-tri(platform), needs at least two assigned reviewers
There was a problem hiding this comment.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee rpoyner-tri(platform), needs at least two assigned reviewers
tools/install/libdrake/test/exported_symbols_test.py line 7 at r2 (raw file):
import unittest # Any symbols whose name starts with one of these strings are okay.
nit Might be worth documenting why we include/exclude symbols by mangled match, rather than demangled match.
There was a problem hiding this comment.
Reviewable status: 1 unresolved discussion, needs at least two assigned reviewers
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status: 1 unresolved discussion, needs at least two assigned reviewers
jwnimmer-tri
force-pushed
the
exported-symbols-test
branch
from
88ef4f1 to
a8a069a
Compare
There was a problem hiding this comment.
+@EricCousineau-TRI for platform review per schedule, please. (Waiting until Thursday is fine.)
Reviewable status: LGTM missing from assignee EricCousineau-TRI(platform)
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3.
Reviewable status: LGTM missing from assignee EricCousineau-TRI(platform)
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: LGTM missing from assignee EricCousineau-TRI(platform)
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1, 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all discussions resolved, LGTM from assignees rpoyner-tri(platform),EricCousineau-TRI(platform)
Towards #17231.
This change is