[workspace] Simplify gfortran to be more platform-agnostic #20583
Conversation
jwnimmer-tri
added
priority: low
release notes: none
|
@drake-jenkins-bot mac-x86-monterey-clang-bazel-experimental-release please |
|
@drake-jenkins-bot mac-x86-monterey-clang-bazel-experimental-release please @drake-jenkins-bot linux-focal-unprovisioned-gcc-wheel-experimental-release please |
|
+@xuchenhan-tri for feature review, please. (I'm load-balancing a multiple PR train.) |
There was a problem hiding this comment.
+@SeanCurtis-TRI for platform review per rotation please.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee SeanCurtis-TRI(platform)
tools/workspace/gfortran/repository.bzl line 13 at r1 (raw file):
dumpversion = execute_or_fail(repo_ctx, [compiler, "-dumpversion"]).stdout repo_ctx.file( "version.bzl",
BTW, when and where is this version.bzl file used?
There was a problem hiding this comment.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee SeanCurtis-TRI(platform)
tools/workspace/gfortran/repository.bzl line 13 at r1 (raw file):
Previously, xuchenhan-tri wrote…
BTW, when and where is this
version.bzlfile used?
At the moment there is just one place:
./tools/workspace/snopt/fortran-ubuntu.bzl:2:load("@gfortran//:version.bzl", COMPILER_MAJOR = "MAJOR")
We use it to toggle some warning flags that are annoyingly version-specific in gfortran.
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all discussions resolved, LGTM from assignees SeanCurtis-TRI(platform),xuchenhan-tri(platform)
Towards #14967.
This change is