[workspace] Remove determine_os logic #21089
Conversation
jwnimmer-tri
added
priority: low
release notes: feature
|
@drake-jenkins-bot linux-jammy-unprovisioned-gcc-wheel-experimental-release please |
|
+@mwoehlke-kitware or +@svenevs perhaps one of you has time for a feature review here? If so, please go ahead (and un-assign the ). |
There was a problem hiding this comment.
\t.
Reviewed 9 of 10 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee svenevs, needs platform reviewer assigned
CMakeLists.txt line 72 at r1 (raw file):
set(MAYBE_RC "tools/ubuntu-${UNIX_DISTRIBUTION_CODENAME}.bazelrc") if(NOT EXISTS "${PROJECT_SOURCE_DIR}/${MAYBE_RC}") message(WARNING "Could NOT find config file ${MAYBE_RC}")
Suggestion:
message
Centralize choice of C++20 to be project-wide, instead of OS-specific. Simplify CMakeLists to use whatever OS codename it finds for the bazel customizations, with only warnings (not errors) when none is found. Overall, these changes remove some barriers to building Drake on non-Ubuntu linuxen.
jwnimmer-tri
force-pushed
the
os-portability-pkgconfig
branch
from
47a9f25 to
0b20c2b
Compare
There was a problem hiding this comment.
+@SeanCurtis-TRI for platform review per schedule, please.
Dismissed @mwoehlke-kitware from a discussion.
Reviewable status: LGTM missing from assignee SeanCurtis-TRI(platform)
CMakeLists.txt line 72 at r1 (raw file):
set(MAYBE_RC "tools/ubuntu-${UNIX_DISTRIBUTION_CODENAME}.bazelrc") if(NOT EXISTS "${PROJECT_SOURCE_DIR}/${MAYBE_RC}") message(WARNING "Could NOT find config file ${MAYBE_RC}")
Done.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: LGTM missing from assignee SeanCurtis-TRI(platform)
There was a problem hiding this comment.
Reviewed 9 of 10 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all discussions resolved, LGTM from assignees SeanCurtis-TRI(platform),mwoehlke-kitware
This reverts commit 0e2b6ae.
Centralize choice of C++20 to be project-wide, instead of OS-specific. Simplify CMakeLists to use whatever OS codename it finds for the bazel customizations, with only warnings (not errors) when none is found. Overall, these changes remove some barriers to building Drake on non-Ubuntu linuxen.
Centralize choice of C++20 to be project-wide, instead of OS-specific. Simplify CMakeLists to use whatever OS codename it finds for the bazel customizations, with only warnings (not errors) when none is found. Overall, these changes remove some barriers to building Drake on non-Ubuntu linuxen.
Centralize choice of C++20 to be project-wide, instead of OS-specific.
Simplify CMakeLists to use whatever OS codename it finds for the bazel customizations, with only warnings (not errors) when none is found.
Overall, these changes remove some barriers to building Drake on non-Ubuntu linuxen.
Towards #14967.
This change is