[examples] Clean up visibility and paths #21401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default visibility (for rules that aren't otherwise marked) shall always be private; making example code or models public should always be opt-in. Align opt-in in to public visibility to exactly match things that are installed; if its not installed, then it shouldn't be used outside of Drake. Avoid "subpackages" spelling for visibility; for clarity we should either make things fully public (installed) or else limit to an allow-list of specific other packages one by one. Now that all examples code is suitably private, re-spell the imports to lose the "drake" part of the module namespace. The old spelling of imports is dispreferred and will not work with upcoming bzlmod.
jwnimmer-tri
added
release notes: none
|
+@rpoyner-tri for both reviews, please. |
rpoyner-tri
reviewed
May 7, 2024
There was a problem hiding this comment.
Reviewed 46 of 46 files at r1, all commit messages.
Reviewable status: LGTM missing from assignee rpoyner-tri(platform)
rpoyner-tri
reviewed
May 7, 2024
There was a problem hiding this comment.
Reviewable status:
complete! all discussions resolved, LGTM from assignee rpoyner-tri(platform)
RussTedrake
pushed a commit
to RussTedrake/drake
that referenced
this pull request
Dec 15, 2024
The default visibility (for rules that aren't otherwise marked) shall always be private; making example code or models public should always be opt-in. Align opt-in in to public visibility to exactly match things that are installed; if its not installed, then it shouldn't be used outside of Drake. Avoid "subpackages" spelling for visibility; for clarity we should either make things fully public (installed) or else limit to an allow-list of specific other packages one by one. Now that all examples code is suitably private, re-spell the imports to lose the "drake" part of the module namespace. The old spelling of imports is dispreferred and will not work with upcoming bzlmod.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default visibility (for rules that aren't otherwise marked) shall always be private; making example code or models public should always be opt-in.
Align opt-in in to public visibility to exactly match things that are installed; if its not installed, then it shouldn't be used outside of Drake.
Avoid "subpackages" spelling for visibility; for clarity we should either make things fully public (installed) or else limit to an allow-list of specific other packages one by one.
Now that all examples code is suitably private, re-spell the imports to lose the "drake" part of the module namespace. The old spelling of imports is dispreferred and will not work with upcoming bzlmod (#20731).
Anzu CI has passed vs this PR.
This change is