Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pydrake] Add more examples of memory leaks #21986

Merged

Conversation

jwnimmer-tri
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri commented Oct 3, 2024

Towards #14387.

+@rpoyner-tri for feature review, please.


This change is Reviewable

@jwnimmer-tri jwnimmer-tri added priority: medium release notes: none This pull request should not be mentioned in the release notes labels Oct 3, 2024
Copy link
Contributor

@rpoyner-tri rpoyner-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: needs at least two assigned reviewers

@jwnimmer-tri
Copy link
Collaborator Author

+@xuchenhan-tri for platform review per schedule, please.

Copy link
Contributor

@xuchenhan-tri xuchenhan-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Nice!

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion

a discussion (no related file):
BTW, the amount of "blocks" do not grow linearly when I run the test. Is that expected/do you understand why it's not the case?


Copy link
Collaborator Author

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignees rpoyner-tri(platform),xuchenhan-tri(platform)

a discussion (no related file):

Previously, xuchenhan-tri wrote…

BTW, the amount of "blocks" do not grow linearly when I run the test. Is that expected/do you understand why it's not the case?

No idea. I know that sys.getallocatedblocks() returns a python object which uses a block, so will have some variation depending on whether the number is interned or not, but that would only be a 1-ish block difference, not the 3-10 block variation I see.


@jwnimmer-tri jwnimmer-tri merged commit 3a83ed5 into RobotLocomotion:master Oct 3, 2024
9 checks passed
@jwnimmer-tri jwnimmer-tri deleted the py-memory-leak-more-cases branch October 3, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: medium release notes: none This pull request should not be mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants