[setup] Update cloud packaging for EGL #22197
Conversation
jwnimmer-tri
added
release notes: fix
jwnimmer-tri
force-pushed
the
deepnote
branch
from
cd5b70f
to
b055328
Compare
|
+@rpoyner-tri for feature review, please. |
|
At some point, I should also change this exception message to give better help (e.g., link to a troubleshooting guide): I can do that in this same PR if you like, or save it for a later one? |
There was a problem hiding this comment.
I'm fine with a separate PR for error message improvements.
Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: needs at least two assigned reviewers
|
+@sammy-tri for platform review per schedule, please. |
There was a problem hiding this comment.
Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: 2 unresolved discussions
a discussion (no related file):
nit: there are remaining references to a display server in from_source.md and installation.md which may be stale.
doc/_pages/release_playbook.md line 260 at r1 (raw file):
/opt/drake/share/drake/setup/deepnote/install_nginxIn case the display server is not working later on, this might be a good place to double-check.
nit: should there still be a reference to the display server here?
Add ubuntu dependency on libegl1 so that it can be dlopen'd. Remove xvfb from deepnote.
jwnimmer-tri
force-pushed
the
deepnote
branch
from
b055328
to
2d3f70f
Compare
There was a problem hiding this comment.
Reviewable status:
complete! all discussions resolved, LGTM from assignees rpoyner-tri(platform),sammy-tri(platform)
a discussion (no related file):
Previously, sammy-tri (Sam Creasey) wrote…
nit: there are remaining references to a display server in
from_source.mdandinstallation.mdwhich may be stale.
Good point.
I am rewriting the setup scripts and docs in #22055, so I've filed two reminders there to revisit this as part of the bigger story.
doc/_pages/release_playbook.md line 260 at r1 (raw file):
Previously, sammy-tri (Sam Creasey) wrote…
nit: should there still be a reference to the display server here?
Done (removed).
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
Add ubuntu dependency on libegl1 so that it can be dlopen'd. Document the same in the pip error message sidecar.
Remove xvfb from deepnote. Now that Drake defaults to using EGL, we no longer need a DISPLAY in the cloud.
This change is