[workspace] Build IPOPT from source on macOS #22331
Conversation
jwnimmer-tri
added
priority: low
release notes: fix
jwnimmer-tri
force-pushed
the
mac-ipopt
branch
from
fab7d3f to
9be0c39
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
+@rpoyner-tri we should probably tap you for feature review on this, please. It's low priority, though -- need not happen this CY. |
There was a problem hiding this comment.
checkpoint (obvious stuff). More later.
Reviewed 18 of 26 files at r1, 2 of 3 files at r2.
Reviewable status: LGTM missing from assignee rpoyner-tri(platform), needs at least two assigned reviewers
There was a problem hiding this comment.
Reviewed 5 of 26 files at r1, 1 of 3 files at r2, all commit messages.
Reviewable status: 1 unresolved discussion, needs at least two assigned reviewers
tools/workspace/mumps_internal/repository.bzl line 34 at r2 (raw file):
mumps_internal_repository = repository_rule( doc = """Adds a repository rule for the host mumps library from Ubuntu. This repository is not useful on macOS; the repository rule will evalutate
typo
Suggestion:
evaluate
jwnimmer-tri
force-pushed
the
mac-ipopt
branch
from
9be0c39 to
9dd0cbd
Compare
There was a problem hiding this comment.
+@xuchenhan-tri for platform review, please (load balancing Sean after the break).
Reviewed 5 of 5 files at r3, all commit messages.
Reviewable status: LGTM missing from assignee xuchenhan-tri(platform)
There was a problem hiding this comment.
Reviewed 5 of 5 files at r3, all commit messages.
Reviewable status: LGTM missing from assignee xuchenhan-tri(platform)
There was a problem hiding this comment.
Reviewed 19 of 26 files at r1, 2 of 3 files at r2, 5 of 5 files at r3, all commit messages.
Reviewable status: 2 unresolved discussions
solvers/BUILD.bazel line 1537 at r3 (raw file):
# SPRAL is the default on macOS, so ipopt_solver_test already has # us covered. Only on Ubuntu (where MUMPS is the default) do we # need to run-run this test.
typo? run-run?
tools/workspace/ipopt/package.BUILD.bazel line 7 at r3 (raw file):
package(default_visibility = ["//visibility:public"]) _MESSAGE = "DRAKE DEPRECATED: The @ipopt repository alias is no longer available, and there is no replacement. If you still something related to IPOPT, you may wish to copy the repository rule from a prior Drake release into your project. The deprecated code will be removed from Drake on or after 2025-04-01." # noqa
nit, removal date.
One consequence is that MUMPS is no longer available as one of IPOPT's linear solvers on macOS (because homebrew refuses to accept our pull requests to package MUMPS standalone, after 9 months of us trying). The only linear solver is SPRAL. Remove now-irrelevant ipopt_internal_pkgconfig and therefore rename ipopt_internal_fromsource to just plain ipopt_internal. Remove now-irrelevant IPOPT code from the wheel build. Relatedly, remove TODOs in CLP considering adding support for MUMPS, both because we can't use it on macOS and also because we've recently learned that MUMPS has global variables (is not threadsafe). Deprecate the `@ipopt` repository alias.
jwnimmer-tri
force-pushed
the
mac-ipopt
branch
from
9dd0cbd to
708d2d5
Compare
There was a problem hiding this comment.
Reviewed 3 of 3 files at r4, all commit messages.
Reviewable status:complete! all discussions resolved, LGTM from assignees rpoyner-tri(platform),xuchenhan-tri(platform)
There was a problem hiding this comment.
Reviewed 3 of 3 files at r4, all commit messages.
Reviewable status:
jwnimmer-tri
added
the
release notes: newly deprecated
Towards #21476 and #17231 and #21714.
This change is