Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Small fixes in prep for bzlmod (part deux) #22342

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

jwnimmer-tri
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri commented Dec 20, 2024

In #22330, I missed a couple more instances of @// which didn't show up in drake-external-examples testing but did show up in Anzu. Now I've grepped the whole tree and fixed all of the stragglers.

Towards #20731.


This change is Reviewable

@jwnimmer-tri jwnimmer-tri added priority: medium status: single reviewer ok https://drake.mit.edu/reviewable.html release notes: none This pull request should not be mentioned in the release notes labels Dec 20, 2024
@jwnimmer-tri
Copy link
Collaborator Author

+@xuchenhan-tri for stamping please, if you are still around.

Copy link
Contributor

@xuchenhan-tri xuchenhan-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:x2

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignee xuchenhan-tri(platform)

@jwnimmer-tri jwnimmer-tri merged commit 61a2887 into RobotLocomotion:master Dec 20, 2024
9 of 10 checks passed
@jwnimmer-tri jwnimmer-tri deleted the bzlmod-nits2 branch December 20, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: medium release notes: none This pull request should not be mentioned in the release notes status: single reviewer ok https://drake.mit.edu/reviewable.html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants