[pydrake] Remove some gratuitous uses of python repo constants #22345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwnimmer-tri
added
priority: low
status: single reviewer ok
Configuring the python version in a repository rule goes against best practices for supporting toolchains (and thus, bzlmod). This commit takes a bite out of the problem; future commits that adjust pybind rules will finish the job.
jwnimmer-tri
force-pushed
the
tidy-python-version
branch
from
b9ed548 to
47685d6
Compare
|
+@rpoyner-tri for both reviews, please. |
rpoyner-tri
reviewed
Jan 2, 2025
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status:complete! all discussions resolved, LGTM from assignee rpoyner-tri(platform)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #22346 and #20731.
This change is