[build] Change how CMake details are printed #22420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwnimmer-tri
added
the
release notes: none
jwnimmer-tri
changed the title
Print our verbose build settings when we actually run the build, not during CMake configuration. This is nicer and more accurate anyway, but will soon be required since Bazel loads MODULE.bazel more eagerly than WORKSPACE.bazel and the override_repository generated files do not yet exist during CMake configuration, rather only after CMake generation.
jwnimmer-tri
force-pushed
the
cmake-announce
branch
from
041e3cd to
1d02f4b
Compare
|
+@mwoehlke-kitware for feature review, please? |
There was a problem hiding this comment.
Reviewable status: needs platform reviewer assigned, needs at least two assigned reviewers
|
+@sammy-tri for platform review per schedule, please. |
sammy-tri
reviewed
Jan 9, 2025
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all discussions resolved, LGTM from assignees sammy-tri(platform),mwoehlke-kitware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #20731.
This change is