-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lcmtypes] Add benchmark #22480
[lcmtypes] Add benchmark #22480
Conversation
+@sammy-tri this seems like it might be up your alley for feature review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will review.
Reviewable status: LGTM missing from assignee sammy-tri(platform), needs at least two assigned reviewers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: needs at least two assigned reviewers
+@xuchenhan-tri for platform review, please (tomorrow). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion
lcmtypes/benchmarking/benchmark.cc
line 78 at r1 (raw file):
message.position[i].resize(3, 0); message.quaternion[i].resize(4, 0); }
nit, this seems redundant since the values are already set to zero in the resize above.
Code quote:
for (int i = 0; i < n; ++i) {
message.position[i].resize(3, 0);
message.quaternion[i].resize(4, 0);
}
5b1e51e
to
66f5ea4
Compare
66f5ea4
to
7d5d2cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all discussions resolved, LGTM from assignees sammy-tri(platform),xuchenhan-tri(platform)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all discussions resolved, LGTM from assignees sammy-tri(platform),xuchenhan-tri(platform)
Towards #20761 and therefore towards #17231 and #21868.
The objective here is to have sufficient benchmark coverage that we feel confident switching over the implementation.
Sample output:
This change is