fix: Disables GenericMenu without any sections or items
#30319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f2d9fa3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 29 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
|
Fixes #30159 as well |
|
@dougfabris could you please have a look at this |
dougfabris
requested changes
Sep 8, 2023
|
Hey @dougfabris, I have made the requested changes. Please have a look |
dougfabris
requested changes
Sep 11, 2023
This was referenced Sep 11, 2023
Closed
dougfabris
changed the title
GenericMenu without any sections or items
Codecov Report
@@ Coverage Diff @@
## develop #30319 +/- ##
========================================
Coverage 50.23% 50.23%
========================================
Files 780 780
Lines 14478 14478
Branches 2617 2617
========================================
Hits 7273 7273
Misses 6810 6810
Partials 395 395
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
@anjy7 Can you sign the CLA, please? |
dionisio-bot
bot
added
stat: ready to merge
dougfabris
approved these changes
Sep 18, 2023
done, thank you |
|
@anjy7 Thank you for contributing and helping us! |
dionisio-bot
bot
added
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Sep 19, 2023
…ove/iframeLogin * 'develop' of github.com:RocketChat/Rocket.Chat: (29 commits) fix: Disables `GenericMenu` without any sections or items (#30319) i18n: Language update from LingoHub 🤖 on 2023-09-18Z (#30426) chore: remove connectToCloud option (#30430) chore: remove Troubleshoot options (#30429) chore: bump fuselage packages (#30424) chore: Webhooks page refactor (#30274) chore: color palette changes (#30385) fix: increase cron job check delay to 1 min (#30402) fix: Presence broadcast isn't enabled after license validation (#30282) test: create non private team and readonly team (#30371) Bump version to 6.5.0-develop refactor: Implement functional code for the 'useFilteredApps' hook (#30279) Release 6.4.0-rc.1 Release 6.3.6 regression: Login page callout messages (#30399) test: tests for muting and unmuting (#30286) regression: Fix rooms table not showing teams (#30361) regression: Move queue-timeout setting to CE and remove dependency on waiting queue (#30386) fix: engagement dashboard not working (#30277) Bump 6.3.6 ...
MartinSchoeler
pushed a commit
that referenced
this pull request
Sep 26, 2023
debdutdeb
pushed a commit
that referenced
this pull request
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
The "Create new" button is disabled as it should be when the user doesn't have those permissions
Issue(s)
Fixes #30312
Fixes #30159
Steps to test or reproduce
1.Disable ''Create Private Channels", "Create Public Channels", "Create Team", "Start Discussion", "Start Discussion (Other-User)" and "Create Direct Messages" permissions for users
2.Log in as a normal user
3.Click on the "Create new" menu
Further comments