Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor cloud sync #30401

Merged
merged 8 commits into from
Sep 29, 2023
Merged

chore: refactor cloud sync #30401

merged 8 commits into from
Sep 29, 2023

Conversation

tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Sep 15, 2023 •
edited by jira bot
Loading

Proposed changes (including videos or screenshots)

Issue(s)

NBJ-333

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Sep 15, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 49cd992

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Sep 15, 2023 •
edited
Loading

Codecov Report

Merging #30401 (3271ac7) into develop (bb5fe78) will decrease coverage by 0.13%.
The diff coverage is n/a.

❗ Current head 3271ac7 differs from pull request most recent head 49cd992. Consider uploading reports for the commit 49cd992 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30401      +/-   ##
===========================================
- Coverage    50.93%   50.81%   -0.13%     
===========================================
  Files          809      803       -6     
  Lines        15016    14995      -21     
  Branches      2724     2720       -4     
===========================================
- Hits          7649     7619      -30     
+ Misses        6958     6955       -3     
- Partials       409      421      +12
Flag Coverage Δ
e2e 48.48% <ø> (-0.10%) ⬇️
unit 62.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@tassoevan tassoevan force-pushed the feat/cloud-announcements branch 5 times, most recently from 7cd0755 to 768aa50 Compare September 22, 2023 05:07
@tassoevan tassoevan closed this Sep 22, 2023
@tassoevan tassoevan force-pushed the feat/cloud-announcements branch from c02c160 to 96c268d Compare September 22, 2023 15:18
@tassoevan tassoevan reopened this Sep 22, 2023
@tassoevan tassoevan force-pushed the feat/cloud-announcements branch 2 times, most recently from c7946be to c7d8606 Compare September 25, 2023 15:20
@tassoevan
Empty commit
d2b3346
@tassoevan
feat(cloud): Base for announcements (#30471)
9a6a4dd 
* Empty commit

* Add type for synchronization payload

* Splitting fetching and consumption of sync data

* Normalize registration data

* Expand `Cloud.Announcement`

* Add model for cloud announcements

* Validate the payload

* Use `suretype`

* Refactor a bunch of stuff

* Handle announcements on sync

* Fix typo
@tassoevan tassoevan force-pushed the feat/cloud-announcements branch from 6959e27 to 9a6a4dd Compare September 25, 2023 20:08
@ggazzo ggazzo changed the title feat: feat/cloud-announcements chore: refactor cloud sync Sep 29, 2023
@ggazzo ggazzo marked this pull request as ready for review September 29, 2023 18:00
@ggazzo ggazzo requested review from a team as code owners September 29, 2023 18:00
ggazzo
ggazzo previously approved these changes Sep 29, 2023
View reviewed changes
sampaiodiego
sampaiodiego requested changes Sep 29, 2023
View reviewed changes
apps/meteor/server/models/raw/CloudAnnouncements.ts Outdated Show resolved Hide resolved
apps/meteor/server/models/raw/CloudAnnouncements.ts Outdated Show resolved Hide resolved
packages/core-typings/package.json Outdated Show resolved Hide resolved
packages/core-typings/src/cloud/Announcement.ts Show resolved Hide resolved
@ggazzo ggazzo force-pushed the feat/cloud-announcements branch from 4e414bd to f1ddd78 Compare September 29, 2023 20:13
@ggazzo ggazzo force-pushed the feat/cloud-announcements branch from f1ddd78 to 56aa8bf Compare September 29, 2023 20:16
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Sep 29, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Sep 29, 2023
@ggazzo ggazzo merged commit 05f613f into develop Sep 29, 2023
8 of 9 checks passed
@ggazzo ggazzo deleted the feat/cloud-announcements branch September 29, 2023 21:21
@zahidhussain998
Copy link

hey, i would like to work on this issue

gabriellsh added a commit that referenced this pull request Oct 3, 2023
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into chor…
006abf3 
…e/translationCdn

* 'develop' of github.com:RocketChat/Rocket.Chat: (117 commits)
  chore: do not focus messagebox on mobile devices (#30553)
  chore: add the new endpoints to sync with cloud (#30546)
  fix: in forward search field, user cannot be found by name (Full Name) (#29663)
  chore: set license public key v3 with v2 (#30548)
  chore: adjust callbacks return type (#30547)
  chore: Delete Trigger Endpoint (#30533)
  test: adding missing verifications on message-actions (#30531)
  refactor: Oembed backend (#30228)
  test: refactor API E2E tests for groups endpoints (#30523)
  test: adding missing verifications on threads (#30528)
  chore: refactor cloud sync (#30401)
  refactor: Omni logs (#30322)
  refactor: Livechat Header -> ts (#30255)
  chore: Deprecate un-used meteor method for omnichannel analytics (#30421)
  feat: add supported versions + minimum clients versions to the info endpoint (#30178)
  feat: Auto-enable autotranslate (#30370)
  chore: Prevent call license and registration status endpoints when not enough permission (#30336)
  ci: Security/GitHub jira integration (#29776)
  feat: License V3 (#30287)
  chore: move Omnichannel toolbox section from sidebar room list (#30502)
  ...
debdutdeb pushed a commit that referenced this pull request Oct 26, 2023
@tassoevan @debdutdeb
chore: refactor cloud sync (#30401)
36dd047
@pierre-lehnen-rc pierre-lehnen-rc mentioned this pull request Nov 4, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

@ggazzo ggazzo ggazzo approved these changes

Assignees
No one assigned
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tassoevan @zahidhussain998 @ggazzo @sampaiodiego