Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Validate monitors data access #30593

Merged
merged 8 commits into from
Oct 10, 2023
Merged

test: Validate monitors data access #30593

merged 8 commits into from
Oct 10, 2023

Conversation

KevLehman
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Oct 6, 2023

⚠️ No Changeset found

Latest commit: 489076d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Oct 6, 2023
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #30593 (489076d) into develop (2124868) will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30593      +/-   ##
===========================================
- Coverage    51.29%   51.17%   -0.12%     
===========================================
  Files          811      803       -8     
  Lines        15080    15085       +5     
  Branches      2754     2762       +8     
===========================================
- Hits          7735     7720      -15     
- Misses        6935     6938       +3     
- Partials       410      427      +17     
Flag Coverage Δ
e2e 48.48% <ø> (-0.08%) ⬇️
unit 64.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Oct 9, 2023
@KevLehman KevLehman marked this pull request as ready for review October 10, 2023 16:46
@KevLehman KevLehman requested review from a team as code owners October 10, 2023 16:46
@KevLehman KevLehman added the stat: ready to merge PR tested and approved waiting for merge label Oct 10, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 10, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 10, 2023
@kodiakhq kodiakhq bot merged commit 03315b2 into develop Oct 10, 2023
@kodiakhq kodiakhq bot deleted the test/monitor-scenarios branch October 10, 2023 22:01
gabriellsh added a commit that referenced this pull request Oct 11, 2023
…/mentionBot

* 'develop' of github.com:RocketChat/Rocket.Chat:
  fix: Auto-translate doesn't work on E2E rooms (#30369)
  test: Validate monitors data access (#30593)
  fix: reset file input after uploading file (#30529)
  refactor: AutoCompleteTagsMultiple to TS (#30577)
  fix: DM room stay "read only" after the deactivate and reactivate user with "guest" role (#30459)
  fix: Change plan name from Enterprise to Premium on marketplace filtering (#30616)
  regression: test license from cloud (#30609)
  fix: Unable to send attachments via email as an omni-agent (#30525)
  ci: fix lint task
  fix: cloud alerts (#30607)
  feat: License trigger cloud sync after reach limits (#30603)
  chore: Change plan name Enterprise to Premium on marketplace (#30487)
  chore: Improve cache of static files (#30290)
  regression: Undefined MAC count on startup cloud sync (#30605)
  chore: Change Records page name to Reports (#30513)
debdutdeb pushed a commit that referenced this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants