Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: processWebhookMessage & chat.postMessage types #30652

Merged
merged 12 commits into from
Oct 26, 2023

Conversation

gabriellsh
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Oct 16, 2023

⚠️ No Changeset found

Latest commit: fb4c9e7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #30652 (fb4c9e7) into develop (4bb7e72) will decrease coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30652      +/-   ##
===========================================
- Coverage    51.22%   50.99%   -0.23%     
===========================================
  Files          811      808       -3     
  Lines        15114    15208      +94     
  Branches      2758     2827      +69     
===========================================
+ Hits          7742     7756      +14     
- Misses        6961     7011      +50     
- Partials       411      441      +30     
Flag Coverage Δ
e2e 48.26% <ø> (-0.22%) ⬇️
unit 63.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@gabriellsh gabriellsh marked this pull request as ready for review October 17, 2023 15:56
@gabriellsh gabriellsh requested review from a team as code owners October 17, 2023 15:56
…chat.postMessage

* 'develop' of github.com:RocketChat/Rocket.Chat:
  fix: inconsistent behavior when removing subscriptions and inquiries (#30572)
  fix: Handle AWS S3 Re-Authentication via s3.getSignedUrlPromise (#30642)
  test: wait for the name update finish (#30663)
  regression: Restore default limits to community apps (#30611)
  refactor: Move functions out of `Livechat.js` (#30650)
  chore: remove license v3 public key envvar (#30646)
  fix: Read receipts are not created on the first time a user reads a room (#30610)
  fix: licenses.info endpoint only available for admins (#30644)
@gabriellsh gabriellsh requested a review from a team as a code owner October 18, 2023 23:01
tassoevan
tassoevan previously approved these changes Oct 19, 2023
…chat.postMessage

* 'develop' of github.com:RocketChat/Rocket.Chat:
  docs: Fixed typo in FEATURES.md (#30683)
  refactor(uikit): uikit interactions (#30534)
  feat: add trial flag to licenses.info endpoint (#30662)
  refactor: Small files to typescript (#30665)
  feat: Added new setting 'Hide conversation after closing' (#30591)
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Oct 26, 2023
@gabriellsh gabriellsh removed the stat: ready to merge PR tested and approved waiting for merge label Oct 26, 2023
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 26, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 26, 2023
@kodiakhq kodiakhq bot merged commit 46d5302 into develop Oct 26, 2023
43 checks passed
@kodiakhq kodiakhq bot deleted the fix/chat.postMessage branch October 26, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants