Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove redundant indexes #30914

Merged
merged 1 commit into from
Nov 10, 2023
Merged

chore: remove redundant indexes #30914

merged 1 commit into from
Nov 10, 2023

Conversation

sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented Nov 9, 2023

Proposed changes (including videos or screenshots)

the indexes removed are actually redundant and are prefixes of other compound indexes.

Unused indexes consume storage space and increase write latency.

Issue(s)

Steps to test or reproduce

Further comments

@sampaiodiego sampaiodiego requested a review from a team as a code owner November 9, 2023 20:09
Copy link

changeset-bot bot commented Nov 9, 2023

⚠️ No Changeset found

Latest commit: f333899

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@debdutdeb
Copy link
Member

Don't we need migrations to actually remove those indexes from mongo?

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Nov 9, 2023
@sampaiodiego
Copy link
Member Author

Don't we need migrations to actually remove those indexes from mongo?

yes, we'd need a migration to remove them.. we're avoiding migrations during minor releases though, so we'd need to "schedule" a migration for the next major..

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #30914 (f333899) into develop (3963ef5) will decrease coverage by 0.30%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30914      +/-   ##
===========================================
- Coverage    51.42%   51.12%   -0.30%     
===========================================
  Files          814      813       -1     
  Lines        15046    15232     +186     
  Branches      2732     2814      +82     
===========================================
+ Hits          7737     7788      +51     
- Misses        6902     7007     +105     
- Partials       407      437      +30     
Flag Coverage Δ
e2e 48.16% <ø> (-0.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@kodiakhq kodiakhq bot merged commit e05a530 into develop Nov 10, 2023
47 checks passed
@kodiakhq kodiakhq bot deleted the remove-duplicated-indexes branch November 10, 2023 12:33
@sampaiodiego
Copy link
Member Author

already created this as a follow up #30918

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants