Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migration to remove redundant indexes #30918

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented Nov 10, 2023

ARCH-1295

Proposed changes (including videos or screenshots)

Complement to #30914 for next major version

Issue(s)

Steps to test or reproduce

Further comments

@sampaiodiego sampaiodiego requested a review from a team as a code owner November 10, 2023 13:10
Copy link

changeset-bot bot commented Nov 10, 2023

⚠️ No Changeset found

Latest commit: d211d3f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sampaiodiego sampaiodiego marked this pull request as draft November 10, 2023 13:10
@sampaiodiego sampaiodiego added this to the 7.0.0 milestone Nov 10, 2023
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.64%. Comparing base (11a47b6) to head (d211d3f).
Report is 1 commits behind head on release-7.0.0.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release-7.0.0   #30918   +/-   ##
==============================================
  Coverage          74.64%   74.64%           
==============================================
  Files                437      437           
  Lines              20485    20485           
  Branches            5252     5252           
==============================================
  Hits               15291    15291           
  Misses              4582     4582           
  Partials             612      612           
Flag Coverage Δ
unit 74.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

dionisio-bot bot commented Apr 12, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@sampaiodiego sampaiodiego force-pushed the migration-to-remove-redundant-indexes branch from 0dabcaf to dd48d0a Compare October 14, 2024 20:32
@sampaiodiego sampaiodiego changed the base branch from develop to release-7.0.0 October 14, 2024 20:32
@sampaiodiego sampaiodiego marked this pull request as ready for review October 14, 2024 20:37
Copy link
Contributor

github-actions bot commented Oct 14, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-30918/
on branch gh-pages at 2024-10-15 01:35 UTC

@ggazzo ggazzo requested review from a team as code owners October 15, 2024 00:45
@ggazzo ggazzo force-pushed the migration-to-remove-redundant-indexes branch from ae0e0e4 to e169558 Compare October 15, 2024 00:50
@ggazzo ggazzo force-pushed the migration-to-remove-redundant-indexes branch from 4a5d1c0 to d211d3f Compare October 15, 2024 00:55
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Oct 15, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 15, 2024
@ggazzo ggazzo merged commit 2b84a46 into release-7.0.0 Oct 15, 2024
50 of 52 checks passed
@ggazzo ggazzo deleted the migration-to-remove-redundant-indexes branch October 15, 2024 03:21
ggazzo added a commit that referenced this pull request Oct 17, 2024
ggazzo added a commit that referenced this pull request Oct 17, 2024
ggazzo added a commit that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants