Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use external service for triggers #31268

Merged
merged 71 commits into from
Mar 12, 2024
Merged

feat: Use external service for triggers #31268

merged 71 commits into from
Mar 12, 2024

Conversation

KevLehman
Copy link
Contributor

@KevLehman KevLehman commented Dec 18, 2023

Proposed changes (including videos or screenshots)

Issue(s)

PROSVC-37

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Dec 18, 2023

🦋 Changeset detected

Latest commit: 13967a7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/core-typings Minor
@rocket.chat/livechat Minor
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Major
@rocket.chat/model-typings Patch
@rocket.chat/rest-typings Minor
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/models Patch
@rocket.chat/ddp-client Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.42%. Comparing base (871efa5) to head (13967a7).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31268      +/-   ##
===========================================
- Coverage    54.51%   54.42%   -0.09%     
===========================================
  Files         2291     2289       -2     
  Lines        50517    50477      -40     
  Branches     10315    10316       +1     
===========================================
- Hits         27537    27471      -66     
- Misses       20490    20506      +16     
- Partials      2490     2500      +10     
Flag Coverage Δ
e2e 53.44% <ø> (-0.07%) ⬇️
e2e-api 39.97% <ø> (-0.18%) ⬇️
unit 75.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Mar 7, 2024
MarcosSpessatto
MarcosSpessatto previously approved these changes Mar 7, 2024
@aleksandernsilva aleksandernsilva requested a review from ggazzo March 7, 2024 13:42
@kodiakhq kodiakhq bot removed the stat: ready to merge PR tested and approved waiting for merge label Mar 8, 2024
Copy link
Contributor

kodiakhq bot commented Mar 8, 2024

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: conflict labels Mar 12, 2024
@aleksandernsilva aleksandernsilva removed the stat: ready to merge PR tested and approved waiting for merge label Mar 12, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 12, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 12, 2024
@kodiakhq kodiakhq bot merged commit b9e897a into develop Mar 12, 2024
45 checks passed
@kodiakhq kodiakhq bot deleted the feat/triggers-omni branch March 12, 2024 19:06
gabriellsh added a commit that referenced this pull request Mar 12, 2024
…modalRegions

* 'develop' of github.com:RocketChat/Rocket.Chat:
  regression: Timestamp missing milliseconds (#31963)
  regression: Livechat offline color not being applied (#31962)
  feat: Use external service for triggers (#31268)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad: omnichannel stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants