Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New users page all tab #31917

Merged
merged 43 commits into from
May 6, 2024
Merged

feat: New users page all tab #31917

merged 43 commits into from
May 6, 2024

Conversation

rique223
Copy link
Contributor

@rique223 rique223 commented Mar 6, 2024

Proposed changes (including videos or screenshots)

This PR introduces the All tab to the new user page tab layout and adds the "Registration status" column to the users table:

Demo image:
image

Issue(s)

Steps to test or reproduce

Further comments

Blocked by: #31898
Related to: #30236
Jira: WM-51

rique223 added 6 commits March 5, 2024 14:07
Created a helper function named isSMTPConfigured.ts to run when calling the smtp.check endpoint of the misc.ts group.
Created the two new endpoints that represent the back-end for the new users page.
Added a tab layout to the new users page, created the useFilteredUsers custom hook and implemented it. Also created necessary typing and translation entries.
Copy link

changeset-bot bot commented Mar 6, 2024

🦋 Changeset detected

Latest commit: ba02acb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 34 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/core-typings Minor
@rocket.chat/i18n Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/rest-typings Minor
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/mock-providers Patch
@rocket.chat/web-ui-registration Major
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/models Patch
@rocket.chat/ddp-client Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/uikit-playground Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 72.30769% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 55.54%. Comparing base (7d5bdde) to head (ba02acb).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31917      +/-   ##
===========================================
- Coverage    55.55%   55.54%   -0.01%     
===========================================
  Files         2406     2406              
  Lines        52882    52874       -8     
  Branches     10861    10860       -1     
===========================================
- Hits         29376    29369       -7     
+ Misses       20900    20895       -5     
- Partials      2606     2610       +4     
Flag Coverage Δ
e2e 54.78% <72.30%> (-0.01%) ⬇️
unit 73.55% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Added a new column to the users table called registration status that shows the status of the current user. Also created new translation entries.
Copy link
Contributor

dionisio-bot bot commented Apr 8, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@rique223 rique223 removed this from the 7.0 milestone Apr 10, 2024
Base automatically changed from feat/new-user-panel-backend to develop April 20, 2024 15:59
@rique223 rique223 marked this pull request as ready for review April 23, 2024 20:48
@rique223 rique223 requested review from a team as code owners April 23, 2024 20:48
@rique223 rique223 modified the milestones: 6.8, 6.9 Apr 26, 2024
@rique223 rique223 added the stat: QA assured Means it has been tested and approved by a company insider label Apr 26, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 26, 2024
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Apr 26, 2024
@dougfabris dougfabris removed the stat: QA assured Means it has been tested and approved by a company insider label May 6, 2024
@casalsgh casalsgh added the stat: QA assured Means it has been tested and approved by a company insider label May 6, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label May 6, 2024
@kodiakhq kodiakhq bot merged commit ff4e396 into develop May 6, 2024
40 of 42 checks passed
@kodiakhq kodiakhq bot deleted the feat/new-user-panel-all branch May 6, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants