Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: i18n missing fallback language #33440

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

aleksandernsilva
Copy link
Contributor

@aleksandernsilva aleksandernsilva commented Oct 3, 2024

Proposed changes (including videos or screenshots)

Introduced #33175

Issue(s)

Steps to test or reproduce

Further comments

CORE-710

Copy link
Contributor

dionisio-bot bot commented Oct 3, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 3, 2024

⚠️ No Changeset found

Latest commit: eebe775

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@aleksandernsilva aleksandernsilva marked this pull request as ready for review October 3, 2024 23:22
@aleksandernsilva aleksandernsilva requested a review from a team as a code owner October 3, 2024 23:22
Copy link
Contributor

github-actions bot commented Oct 3, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-10-04 04:42 UTC

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.36%. Comparing base (74942f3) to head (eebe775).
Report is 1 commits behind head on release-6.13.0.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           release-6.13.0   #33440   +/-   ##
===============================================
  Coverage           58.36%   58.36%           
===============================================
  Files                2692     2692           
  Lines               65282    65282           
  Branches            14728    14728           
===============================================
  Hits                38102    38102           
  Misses              24402    24402           
  Partials             2778     2778           
Flag Coverage Δ
unit 75.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Oct 4, 2024
@scuciatto scuciatto added the stat: ready to merge PR tested and approved waiting for merge label Oct 4, 2024
@kodiakhq kodiakhq bot merged commit eca2906 into release-6.13.0 Oct 4, 2024
54 checks passed
@kodiakhq kodiakhq bot deleted the regression/i18n-fallback branch October 4, 2024 04:42
@aleksandernsilva aleksandernsilva added this to the 6.13 milestone Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants