-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix sorting of usernames in the member-list #34141
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Hey please check this Pull Request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorting comes from MongoDB automatically. You can see on L1080 for example that we're passing a sort
property, that one is sent to MongoDB which returns the data sorted. Same happens on other files.
So we don't need to sort in memory.
well the issue is it is not returning a sorted data from the database |
so it is better if after getting the dat from the database we return a sorted list to the call |
Where is the github issue with a completed template documenting this? Some random PR will get nowhere fast. Also read this please. https://gist.github.com/reetp/b0ba4e3d0ea2ff48ca9da00a5a647d42 |
Hey I fixed,