Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix sorting of usernames in the member-list #34141

Closed
wants to merge 1 commit into from

Conversation

SaraswatSahoo
Copy link

@SaraswatSahoo SaraswatSahoo commented Dec 8, 2024

Hey I fixed,

  1. the sorting problem of the usernames in the member-list for all room types \
  2. by adding a sorting function at all three endpoint channels.members, groups.members, im.members before returning the member list.\

241209_12h22m42s_screenshot

Copy link
Contributor

dionisio-bot bot commented Dec 8, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Dec 8, 2024

⚠️ No Changeset found

Latest commit: 0bc2860

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@SaraswatSahoo
Copy link
Author

Hey please check this Pull Request.

Copy link
Contributor

@KevLehman KevLehman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorting comes from MongoDB automatically. You can see on L1080 for example that we're passing a sort property, that one is sent to MongoDB which returns the data sorted. Same happens on other files.

So we don't need to sort in memory.

@SaraswatSahoo
Copy link
Author

well the issue is it is not returning a sorted data from the database

@SaraswatSahoo
Copy link
Author

so it is better if after getting the dat from the database we return a sorted list to the call
if i am wrong please brief me

@reetp
Copy link

reetp commented Dec 10, 2024

well the issue is it is not returning a sorted data from the database

Where is the github issue with a completed template documenting this?

Some random PR will get nowhere fast.

Also read this please.

https://gist.github.com/reetp/b0ba4e3d0ea2ff48ca9da00a5a647d42

@SaraswatSahoo SaraswatSahoo closed this by deleting the head repository Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants