fix(mp3-encoder): Suppress assertion #1481
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
It suppresses assertions at the LAME encoding due to unknown
NaN
values.Issue(s)
Further comments
This is the original
assert
function: https://github.com/zhuker/lamejs/blob/090eaa9b7e90abb81939145f13be2bdcd06ac5e6/src/js/common.js#L148-L150During investigation, the input buffers showed a small segment of
NaN
values instead of the expected typed Float32 numbers. It couldn't be determined where they are allocated, because they seen to exist prior to theflush
call. Since there is noasync
function or callbacks at play (as the original code was transpiled from single-threaded Java code), the hypothesis ofmessage
events out of sync at the worker thread can be disregarded. One interesting thing to note is that when using a external microphone instead of Macbook's built-in microphone did not generated theNaN
values; it might indicate a bug with the channel enumeration.