Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mp3-encoder): Suppress assertion #1481

Merged
merged 1 commit into from
Nov 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/ninety-monkeys-notice.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@rocket.chat/mp3-encoder': patch
---

Suppressed assertions at the LAME encoding due to unknown `NaN` values
7 changes: 5 additions & 2 deletions packages/mp3-encoder/src/lame/assert.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
export function assert(
condition: boolean,
message?: string,
_message?: string,
): asserts condition {
if (!condition) {
throw new Error(message);
// TODO: There is a condition generating multiple NaN values that was never
// addressed in the original code and is not clear how to handle it.
// Originally this assertion was commented out, probably because of it.
// throw new Error(message);
}
}
Loading