test pr #2
Open
test pr #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: bump version to 8.0.0-beta.2 w/ changelog * tweak * tweak2
Fixes a handful of comments where we made some typos by saying "the the".
add Chrome OS screen reader support add details about the CDK remove unused link definitions
* Moves the `VERSION` export to the the `core` secondary entry-point. This ensures that the V8 package schematics don't resolve the `VERSION` symbol to the incorrect `@angular/material/typings` module name. * Removes the unused and outdated material subpackages test case that has been replaced with a working one. * Ensures that the V8 material imports rule resolves the symbol from the imported identifier and not from the aliased one (minor cleanup; no effect as we resolve the identifer to the original symbol anyway; just slower)
…lar#15782) * 3.1. Add MDC to deps Adds MDC as a peer dependency and updates various build and test config files accordingly. * 3.2. Add the new component skeleton Adds files for MDC-based MatCheckbox. * 3.3. Add a demo for the new component Adds a demo of the MDC-based MatCheckbox at http://localhost:4200/mdc-checkbox. * 3.4. Copy in the canonical MDC DOM and add the MDC styles Adds the MDCCheckbox DOM and styles to the MDC-based MatCheckbox. * 3.5. Set up the MDC foundation Adds the MDCCheckboxFoundation and MDCFormFieldFoundation and translates the lifecycle setup from their respective components (https://github.com/material-components/material-components-web/blob/master/packages/mdc-checkbox/component.ts and https://github.com/material-components/material-components-web/blob/master/packages/mdc-form-field/component.ts) into our MDC-based MatCheckbox. * 3.6. Add a custom MDC adapter Adds an Angular adapter for MDCCheckboxFoundation and MDCFormFieldFoundation * 3.7. Fill in the missing APIs to match the API of the existing Angular Material component Fills in the remaining APIs on the MDC-based MatCheckbox. * 3.8. Copy over the existing demo page to the MDC-based demo Copies over the demo page for the existing MatCheckbox to the demo page for the MDC-based MatCheckbox. Also adds an additional demo to both pages. * 4.1. Manual inspection and testing Adds ripple using RippleRenderer which results in a smaller size than MatRipple or MDCRipple. Also adds support for disabling animations. * 4.2. Copy over unit tests and update them Copies over all of the tests from the existing MatCheckbox and fixes issues that were uncovered by the tests. * 4.3. Copy over e2e tests if any exist Adds MDC-based MatCheckbox to the e2e app and copies over the tests for the existing MatCheckbox. * 4.4. Add MDC-based component to universal-app Adds a couple examples of the MDC-based MatCheckbox to the universal app. * 5.2. Investigate and fix size regressions Removes usgaes of constants from `MDCRippleFoundation`. It looks like their use was preventing the class from being tree-shaken. Results after removing the constants show that the MDC-based implementation is 3kb smaller: https://github.com/mmalerba/mdc-size-comparison/blob/ee1b73a181c4a23345251656df23574140a747c0/results/size-summary.txt * 8. Add user documentation Adds documentation explaining what this component is and how to experiment with it in your app. * 9.2. Address CI failures and reviewer feedback Fixes unit tests in Edge and approves the new API goldens for checkbox.
…on, menu, radio, and slide-toggle (angular#15828)
…ependency injection (angular#15797) I measured a savings of 0.023ms per CdkPopoverEdit instance at startup. There should also be additional savings in CdkRowHoverContent that I did not measure.
…angular#15843) consistent with cdk and material.
Adds a fixer to the `noImportSpacing` rule so that it can be fixed automatically by IDEs.
…lar#15720) Continuation of angular#15680. Explicitly marks all ViewChild and ContentChild queries so that the timing is consistent for apps using Ivy or ViewEngine.
…gular#15721) This is a continuation of angular#15680. Explicitly marks all ViewChild and ContentChild queries so that the timing is consistent for apps using Ivy or ViewEngine.
…ular#15836) In Ivy `host` objects are merged which means that the animation events will be bound twice to `MatSidenav`. These changes move them into `HostListener` so that they work both in ViewEngine and Ivy.
Fixes the build not waiting for the styles to finish building before starting to compile TS.
…lar#15877) The `@ViewChild` query for TemplateRef here needs to be static because some code paths lead to the overlay being created before change detection has finished for this component. Notably, another component may trigger `focus` on the autocomplete-trigger.
…#15806) Goes through the breaking constructor changes in `material/slide-toggle` for 8.0 BREAKING CHANGES: * `_platform` parameter has been removed from the `MatSlideToggle` constructor.
angular#15805) Fixes the `CdkDrag` not reacting to changes in the `cdkDragFreeDragPosition` input, because we had mispelled something and it wasn't caught by TS since `SimpleChanges` isn't typed. Fixes angular#15765.
* feat(table): add text column for simple columns * minor review changes * fix lint * add note regarding minification * add static true to query for column def * change cell query to static true * revert static query in cell; directly provide cells to column * new goldens
Handles the breaking constructor changes for 8.0 in `material/sidenav`. BREAKING CHANGES: * `viewportRuler` parameter in `MatDrawerContainer` constructor is now required. Also the parameter order has changed as a result.
… inherited (angular#15871) [Based on the discussion here](https://github.com/angular/material2/pull/15857/files#r277058391). Reworks the host listeners in `MatMenuItem` so that extending it works properly both in ViewEngine and Ivy.
Reorganizes the files under `material/menu` so they make a bit more sense. The file for the `mat-menu` **component** isn't called `menu-directive` anymore. Also replaces the unnecessary `menu.ts` which was only re-exporting symbols.
Due to the inheritance changes present in the Ivy refactor, animation host bindings are being inherited into a the SideNav sub component unexpectedly. This patch ensures that SideNav uses the same animation binding as does its super class.
…gular#11538) * fix(card): disable all animations when using NoopAnimationsModule Fixes the card `box-shadow` transition not being disabled when it's inside something with the `NoopAnimationsModule`. Relates to angular#10590. * fix lint * fix api test
Currently our version of Yarn is installed through the "angular/ngcontainer" docker image. This is problematic because in order to be able to update Yarn, we always need to update the docker image to a version that comes with the desired Yarn version. Sometimes there is no docker image with the desired latest Yarn version, and therefore we cannot easily update the Yarn version. Additionally the latest Yarn versions contain various fixes for debugging timeout issues and also have improved logic for restoring existing `node_modules`. This is **essential** to take advantage of the CircleCI caching mechanism.
…ngular#11546) Disables all of the chip animations and transitions when the consumer is using the `NoopAnimationsModule`. Also cleans up some repetitive code. Relates to angular#10590.
…gular#11395) Currently some animations in the tab components don't get disabled, when using the `NoopAnimationsModule`, because they don't go through the Angular animations. These changes ensure that everything will be disabled. Fixes angular#10590.
…ngular#16018) * feat(datepicker): align multi-year-view based on minDate and maxDate If minDate is set (and maxDate not set), let first page begin with minYear. If maxDate is set, let last page end with maxYear, and disable year(s) < minYear (if any) in first page. Fixes angular#10646 * add tests for feat(datepicker): align multi-year-view based on minDate and maxDate * refactor feat(datepicker): align multi-year-view based on minDate and maxDate * omit helper func from public api * fixup, resolve conflict refactor with private methods feat(datepicker): align multi-year-view based on minDate and maxDate * share func feat(datepicker): align multi-year-view based on minDate and maxDate * fix formatting nit
…angular#16234) Renames several APIs for readability
…#16323) Fixes the experimental dialog container not having `aria-modal`.
Fixes `mat-checkbox` showing its hover indication when it's disabled. It looks like the selector for the disabled state was misspelled. Fixes angular#16157.
…rs (angular#16129) In order to make our component inputs which use boolean coercion more consistent with other inputs which aren't declared through setters, we should no longer call `markForCheck` within input setters as Angular automatically runs change detection if input values are updated. This breaks the programmatic usage of these inputs as Angular in that case won't be able to run change detection (since it can't detect that the value of the input changes).. though this is a more general problem with the `OnPush` strategy as we can't have consistent behavior for programmatic input updates without switching *every* input to a setter. Instead, in order to still support programmatic input updates, we should expose a method that allows developers to mark the MDC components as dirty. This is necessary so that developers which _really_ need to update programmatically (e.g. through `ViewChild`) can still update the componet to reflect the changes. The benefit is that we don't need to convert every input to a setter w/ markForCheck in order to make the OnPush inputs behavior consistent. Related to COMP-170
…#16080) Fixes a `mat-list-option` that is added after initialization not being selected, even if it matches the control value. Fixes angular#16062.
We use the `isTouchEvent` any time we need to normalize something between touch and mouse events which happens for every pixel that the user has dragged. These changes switch to using direct comparison, rather than `startsWith`, which should be slightly faster since there's a narrow set of touch event types.
… height (angular#16122) Works around the expansion panel header animating on init, if its header is different from the default one. The original issue comes from the code introduced in angular#13088, but we can't remove that code, because it's there to work around a bug in Angular. Fixes angular#16067.
…#15364) Currently we support the part of the spec where the autocomplete panel is supposed to close when pressing alt + up arrow, however at some point we added more functionality that ends up reopening the panel immediately. These changes ensure that the user is able to close the panel via alt + up arrow.
…lar#16319) This enables users of harness authors to provide an API for querying harnesses based on arbitrary state as given by predicate functions.
RudolfFrederiksen
force-pushed
the
configurable-select-panel-height
branch
from
da53ea0 to
afec1ef
Compare
add option to dynamically set panel max-height on mat-select update mat-select multiselect demo to use panelMaxHeight option fix angular#15803
RudolfFrederiksen
force-pushed
the
configurable-select-panel-height
branch
from
afec1ef to
791e34d
Compare
add max height slider for select demo
fix panelMaxHeight description comment
RudolfFrederiksen
force-pushed
the
configurable-select-panel-height
branch
from
0082291 to
7cbbd7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.