test pr

.circleci/config.yml

@@ -1,4 +1,4 @@
-# Configuration file for https://circleci.com/gh/angular/material2
+# Configuration file for https://circleci.com/gh/angular/components
 
 # Note: YAML anchors allow an object to be re-used, reducing duplication.
 # The ampersand declares an alias for an object, then later the `<<: *name`
@@ -54,31 +54,41 @@ var_8: &gcp_decrypt_token "angular"
 # in sync. Unlike in Travis, we don't need to manually purge the node modules if stale because
 # CircleCI automatically discards the cache if the checksum of the lock file has changed.
 var_9: &yarn_install
-  run: yarn install --frozen-lockfile --non-interactive
+  run:
+    name: "Installing project dependencies"
+    command: yarn install --frozen-lockfile --non-interactive
+
+# Anchor that can be used to download and install Yarn globally in the bash environment.
+var_10: &yarn_download
+  run:
+    name: "Downloading and installing Yarn"
+    command: |
+      touch $BASH_ENV
+      curl -o- -L https://yarnpkg.com/install.sh | PROFILE=$BASH_ENV bash -s -- --version "1.16.0"
 
 # Copies the Bazel config which is specifically for CircleCI to a location where Bazel picks it
 # up and merges it with the project-wide bazel configuration (tools/bazel.rc)
-var_10: &copy_bazel_config
+var_11: &copy_bazel_config
   # Set up the CircleCI specific bazel configuration.
   run: sudo cp ./.circleci/bazel.rc /etc/bazel.bazelrc
 
 # Sets up a different Docker image that includes a moe recent Firefox version which
 # is needed for headless testing.
-var_11: &docker-firefox-image
+var_12: &docker-firefox-image
   # TODO(devversion): Temporarily use a image that includes Firefox 62 because the
   # ngcontainer image does include an old Firefox version that does not support headless.
   - image: circleci/node:11.4.0-browsers
 
 # Attaches the release output which has been stored in the workspace to the current job.
 # https://circleci.com/docs/2.0/workflows/#using-workspaces-to-share-data-among-jobs
-var_12: &attach_release_output
+var_13: &attach_release_output
   attach_workspace:
     at: dist/
 
 # Branch filter that we can specify for jobs that should only run on publish branches. This filter
 # is used to ensure that not all upstream branches will be published as Github builds
 # (e.g. revert branches, feature branches)
-var_13: &publish_branches_filter
+var_14: &publish_branches_filter
   branches:
     only:
       - master
@@ -92,15 +102,15 @@ var_13: &publish_branches_filter
 # In order to reduce duplication we use a YAML anchor that just always excludes the "_presubmit"
 # branch. We don't want to run Circle for the temporary "_presubmit" branch which is reserved
 # for the caretaker.
-var_14: &ignore_presubmit_branch_filter
+var_15: &ignore_presubmit_branch_filter
   branches:
     ignore:
       - "_presubmit"
       - "ivy-2019"
 
 # Runs a script that sets up the Bazel remote execution. This will be used by jobs that run
 # Bazel primarily and should benefit from remote caching and execution.
-var_15: &setup_bazel_remote_execution
+var_16: &setup_bazel_remote_execution
   run:
     name: "Setup bazel RBE remote execution"
     command: ./scripts/circleci/bazel/setup-remote-execution.sh
@@ -131,7 +141,7 @@ jobs:
       - *setup_bazel_remote_execution
 
       - run: bazel build src/... --build_tag_filters=-docs-package
-      - run: bazel test src/... --build_tag_filters=-docs-package
+      - run: bazel test src/... --build_tag_filters=-docs-package --test_tag_filters=-e2e
 
       # Note: We want to save the cache in this job because the workspace cache also
       # includes the Bazel repository cache that will be updated in this job.
@@ -168,7 +178,7 @@ jobs:
       - *copy_bazel_config
       - *setup_bazel_remote_execution
 
-      - run: bazel test e2e/...
+      - run: bazel test src/... --test_tag_filters=e2e
 
   # ------------------------------------------------------------------------------------------
   # Job that runs the unit tests on locally installed browsers (Chrome and Firefox headless).
@@ -180,6 +190,7 @@ jobs:
     steps:
     - *checkout_code
     - *restore_cache
+    - *yarn_download
     - *yarn_install
 
     - run: ./scripts/circleci/run-local-browser-tests.sh
@@ -197,6 +208,7 @@ jobs:
     steps:
       - *checkout_code
       - *restore_cache
+      - *yarn_download
       - *yarn_install
 
       - run: ./scripts/circleci/run-browserstack-tests.sh
@@ -217,6 +229,7 @@ jobs:
     steps:
     - *checkout_code
     - *restore_cache
+    - *yarn_download
     - *yarn_install
 
     - run: ./scripts/circleci/run-saucelabs-tests.sh
@@ -230,6 +243,7 @@ jobs:
     steps:
       - *checkout_code
       - *restore_cache
+      - *yarn_download
       - *yarn_install
       - *attach_release_output
 
@@ -244,6 +258,7 @@ jobs:
     steps:
     - *checkout_code
     - *restore_cache
+    - *yarn_download
     - *yarn_install
 
     - run: yarn gulp ci:prerender
@@ -256,8 +271,10 @@ jobs:
     steps:
       - *checkout_code
       - *restore_cache
+      - *yarn_download
       - *yarn_install
 
+      - run: ./scripts/circleci/lint-bazel-files.sh
       - run: yarn gulp ci:lint
 
   # -------------------------------------------------------------------------------------------
@@ -270,6 +287,7 @@ jobs:
     steps:
       - *checkout_code
       - *restore_cache
+      - *yarn_download
       - *yarn_install
 
       - run: yarn gulp ci:build-release-packages
@@ -341,11 +359,71 @@ jobs:
     steps:
     - *checkout_code
     - *restore_cache
+    - *yarn_download
     - *yarn_install
 
     - run: node ./scripts/circleci/setup-angular-snapshots.js
     - run: ./scripts/circleci/run-local-browser-tests.sh
 
+
+  # ----------------------------------------------------------------------------
+  # Job that runs all Bazel tests against Ivy with the current Angular version
+  # specified in the project dev dependencies.
+  # ----------------------------------------------------------------------------
+  ivy_test:
+    <<: *job_defaults
+    resource_class: xlarge
+    environment:
+      GCP_DECRYPT_TOKEN: *gcp_decrypt_token
+    steps:
+      - *checkout_code
+      - *restore_cache
+      - *copy_bazel_config
+      - *setup_bazel_remote_execution
+      - *yarn_download
+      - *yarn_install
+
+      # Setup Angular ivy snapshots built with ngtsc but locked to a specific tag. We
+      # cannot determine the tag automatically based on the Angular version specified in
+      # the "package.json" because the SHA is not known for the given release. Nor can
+      # we use ngcc to apply the ivy switches because ngcc currently does not handle the
+      # UMD format which is used by Bazel when running tests. UMD processing is in
+      # progress and tracked with FW-85.
+      - run: node ./scripts/circleci/setup-angular-snapshots.js --tag 8.0.0-rc.0-ivy-aot+bd37622
+      # Disable type checking when building with Ivy. This is necessary because
+      # type checking is not complete yet and can incorrectly break compilation.
+      # Issue is tracked with FW-1004.
+      - run: sed -i "s/\(_ENABLE_NG_TYPE_CHECKING = \)True/\1False/g" tools/defaults.bzl
+      # Run project tests with ngtsc and the Ivy Angular packages.
+      - run: bazel build src/... --build_tag_filters=-docs-package --define=compile=aot
+      - run: bazel test src/... --build_tag_filters=-docs-package --define=compile=aot --test_tag_filters=-e2e
+
+  # ----------------------------------------------------------------------------
+  # Job that runs all Bazel tests against Ivy from angular/angular#master.
+  # ----------------------------------------------------------------------------
+  ivy_snapshot_test_cronjob:
+    <<: *job_defaults
+    resource_class: xlarge
+    environment:
+      GCP_DECRYPT_TOKEN: *gcp_decrypt_token
+    steps:
+      - *checkout_code
+      - *restore_cache
+      - *copy_bazel_config
+      - *setup_bazel_remote_execution
+      - *yarn_download
+      - *yarn_install
+
+      # Setup Angular ivy snapshots built with ngtsc.
+      - run: node ./scripts/circleci/setup-angular-snapshots.js --tag master-ivy-aot
+      # Disable type checking when building with Ivy. This is necessary because
+      # type checking is not complete yet and can incorrectly break compilation.
+      # Issue is tracked with FW-1004.
+      - run: sed -i "s/\(_ENABLE_NG_TYPE_CHECKING = \)True/\1False/g" tools/defaults.bzl
+      # Run project tests with ngtsc and the Ivy Angular packages.
+      - run: bazel build src/... --build_tag_filters=-docs-package --define=compile=aot
+      - run: bazel test src/... --build_tag_filters=-docs-package --define=compile=aot --test_tag_filters=-e2e
+
 # ----------------------------------------------------------------------------------------
 # Workflow definitions. A workflow usually groups multiple jobs together. This is useful if
 # one job depends on another.
@@ -360,6 +438,8 @@ workflows:
     jobs:
       - bazel_build_test:
           filters: *ignore_presubmit_branch_filter
+      - ivy_test:
+          filters: *ignore_presubmit_branch_filter
       - api_golden_checks:
           filters: *ignore_presubmit_branch_filter
 
@@ -398,17 +478,20 @@ workflows:
       - lint:
           filters: *ignore_presubmit_branch_filter
 
-  # Snapshot tests workflow that is scheduled to run all specified jobs at midnight everyday.
+  # Snapshot tests workflow that is scheduled to run all specified jobs every hour.
   # This workflow runs various jobs against the Angular snapshot builds from Github.
   snapshot_tests:
     jobs:
-      # Note that we need additional jobs for the nightly snapshot tests because there is no
-      # easy way to detect whether a job runs inside of a cronjob or specific workflow.
-      # See: https://circleci.com/ideas/?idea=CCI-I-295
+      # Note that we need additional jobs for the cronjob snapshot tests because there
+      # is no easy way to detect whether a job runs inside of a cronjob or specific
+      # workflow. See: https://circleci.com/ideas/?idea=CCI-I-295
       - snapshot_tests_local_browsers
+      # TODO(devversion): Renable once we are able to update to the version of angular 
+      # and bazel build rules which corrects our errors.
+      # - ivy_snapshot_test_cronjob
     triggers:
       - schedule:
-          cron: "0 0 * * *"
+          cron: "0 * * * *"
           filters:
             branches:
               only:

.editorconfig

@@ -0,0 +1,6 @@
+root = true
+
+[*]
+end_of_line = lf
+insert_final_newline = true
+indent_style = space