Design highlevel API #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Users of the library shouldn't take care of these details. Future commits will also add more high-level functionality for the gripper's features. We needed to adjust some tests and now require the BKS simulator for most communication-related testing.
That's a better usage of system resources.
We'll call this in every high-level function. This leads to less code and is the common practice with SCHUNK modules.
We'll use this in all high-level functions.
That's now in line with the rest of the bit operations.
All of these high-level api functions will wrap bit-related operations and module interaction as good as possible. This will lead to a thin ROS2 driver wrapper.
This is now as thin as we want it. Also drop receiving the module's state periodically in the driver. The library does that now.
stefanscherzinger
force-pushed
the
highlevel-api
branch
from
c862bc0 to
3804d57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
We need a high-level API that wraps all bit-related operations and module interaction as good as possible.
This will lead to a thin ROS2 driver wrapper.
Steps