Closes #591 | Add/Update medisco #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrqorib
requested review from
holylovenia,
SamuelCahyawijaya,
sabilmakbar,
jamesjaya,
yongzx,
gentaiscool,
ljvmiranda921,
jensan-1,
danjohnvelasco,
MJonibek and
tellarin
as code owners
holylovenia
removed request for
tellarin,
gentaiscool,
jamesjaya,
SamuelCahyawijaya,
holylovenia,
yongzx,
danjohnvelasco,
jensan-1 and
sabilmakbar
MJonibek
requested changes
May 14, 2024
There was a problem hiding this comment.
@mrqorib Thank you for your work. Please address changes from @ljvmiranda921 . Also please run make command for reformatting and address errors:
Co-authored-by: Lj Miranda <[email protected]>
|
Thank you @ljvmiranda921 and @MJonibek for the review! I apologize for missing the make file step |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #591
Checkbox
seacrowd/sea_datasets/{my_dataset}/{my_dataset}.py(please use only lowercase and underscore for dataset folder naming, as mentioned in dataset issue) and its__init__.pywithin{my_dataset}folder._CITATION,_DATASETNAME,_DESCRIPTION,_HOMEPAGE,_LICENSE,_LOCAL,_URLs,_SUPPORTED_TASKS,_SOURCE_VERSION, and_SEACROWD_VERSIONvariables._info(),_split_generators()and_generate_examples()in dataloader script.BUILDER_CONFIGSclass attribute is a list with at least oneSEACrowdConfigfor the source schema and one for a seacrowd schema.datasets.load_datasetfunction.python -m tests.test_seacrowd seacrowd/sea_datasets/<my_dataset>/<my_dataset>.pyorpython -m tests.test_seacrowd seacrowd/sea_datasets/<my_dataset>/<my_dataset>.py --subset_id {subset_name_without_source_or_seacrowd_suffix}.