Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #293: SingleEngineeringModel principle implemented #473

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Fix #293: SingleEngineeringModel principle implemented #473

merged 1 commit into from
Oct 10, 2023

Conversation

antoineatstariongroup
Copy link
Contributor

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the COMET-WEB code style guidelines
  • I have provided test coverage for my change (where applicable)

Description

Fix #293

  • SingleEngineeringModelApplicationBase and SingleEngineeringModelApplicationTemplate implemented for pages that only need the EngineeringModel context
  • ApplicationBase and ApplicationTemplate implemented for pages that only need to react to SessionRefresh
  • Related VMs implemented

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

78.1% 78.1% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@antoineatstariongroup antoineatstariongroup merged commit 7ecf6b7 into development Oct 10, 2023
@antoineatstariongroup antoineatstariongroup deleted the feat/GH293-single-engineeringmodel-template branch October 10, 2023 14:12
This was referenced Oct 10, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omaratstariongroup omaratstariongroup omaratstariongroup approved these changes

@nathanatstariongroup nathanatstariongroup nathanatstariongroup approved these changes

@lxatstariongroup lxatstariongroup Awaiting requested review from lxatstariongroup

@Robbware Robbware Awaiting requested review from Robbware

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Template for Page that is bound to an EngineeringModel
3 participants
@antoineatstariongroup @nathanatstariongroup @omaratstariongroup