Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(packages/sui-lint): update line length to 120 characters #1651

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

jordevo
Copy link
Contributor

@jordevo jordevo commented Oct 20, 2023

Description

New screens are wider and have larger resolutions so it seems it's about time to be able to read our code on longer than 80-character lines.

Code chunk with 80-character lines:
image

Same code chunk with 120-character lines:
image

Related Issue

N/A

Example

N/A

@@ -8,7 +8,7 @@ module.exports = {
/* Support optional chaining new ES feature -> ? */
optionalChaining: true,
/* Specify the line length that the printer will wrap on. */
printWidth: 80,
printWidth: 120,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we set it to 200? or 300? 😂 (cc @carlosvillu)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

300 even better !!!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a 50% increase already but I agree... even 120 characters may feel short.

Copy link
Contributor

@AgonisticKatai AgonisticKatai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😝 Por fin!!!

Copy link
Contributor

@oegea oegea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I often use my macbook pro integrated screen to code, and it supports more or less 100 characters with my standard layout, with this new config it will exceed its max line length a bit 😭

@oriolpuig
Copy link
Contributor

I often use my macbook pro integrated screen to code, and it supports more or less 100 characters with my standard layout, with this new config it will exceed its max line length a bit 😭

Then, If I was you, I would think seriously to come back to the office @oegea :trollface:

@jordevo
Copy link
Contributor Author

jordevo commented Oct 20, 2023

I often use my macbook pro integrated screen to code, and it supports more or less 100 characters with my standard layout, with this new config it will exceed its max line length a bit 😭

image

I guess it depends on the zoom factor... this is what I feel as a comfortable layout on my macbook pro 16-inch screen, Retina XDR display at 1728 × 1117. But obviously I understand larger size text can feel more comfortable for some people.

@jordevo jordevo merged commit 6f7f758 into master Nov 15, 2023
1 check passed
@jordevo jordevo deleted the feat-sui-lint-line-length-120 branch November 15, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.