-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(packages/sui-lint): update line length to 120 characters #1651
Conversation
@@ -8,7 +8,7 @@ module.exports = { | |||
/* Support optional chaining new ES feature -> ? */ | |||
optionalChaining: true, | |||
/* Specify the line length that the printer will wrap on. */ | |||
printWidth: 80, | |||
printWidth: 120, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we set it to 200? or 300? 😂 (cc @carlosvillu)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
300 even better !!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's a 50% increase already but I agree... even 120 characters may feel short.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😝 Por fin!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I often use my macbook pro integrated screen to code, and it supports more or less 100 characters with my standard layout, with this new config it will exceed its max line length a bit 😭
Then, If I was you, I would think seriously to come back to the office @oegea |
Description
New screens are wider and have larger resolutions so it seems it's about time to be able to read our code on longer than 80-character lines.
Code chunk with 80-character lines:
Same code chunk with 120-character lines:
Related Issue
N/A
Example
N/A