Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR] apply new linting rules #1665

Closed
wants to merge 36 commits into from
Closed

[REFACTOR] apply new linting rules #1665

wants to merge 36 commits into from

Conversation

kikoruiz
Copy link
Member

apply new linting rules added on #1651

@kikoruiz
refactor(packages/babel-preset-sui): apply new linting rules
f15e4b3
@kikoruiz
refactor(packages/sui-bundler): apply new linting rules
5c321db
@kikoruiz
refactor(packages/sui-ci): apply new linting rules
d241885
@kikoruiz
refactor(packages/sui-consents): apply new linting rules
5d739a2
@kikoruiz
refactor(packages/sui-critical-css-middleware): apply new linting rules
35110bd
@kikoruiz
refactor(packages/sui-critical-css): apply new linting rules
e97b076
@kikoruiz
refactor(packages/sui-dashboard): apply new linting rules
76feafe
@kikoruiz
refactor(packages/sui-decorators): apply new linting rules
e0aaf39
@kikoruiz
refactor(packages/sui-domain): apply new linting rules
7fcecad
@kikoruiz
refactor(packages/sui-helpers): apply new linting rules
a78aaad
@kikoruiz
refactor(packages/sui-hoc): apply new linting rules
9ed2c95
@kikoruiz
refactor(packages/sui-html-tagger): apply new linting rules
64ecf0d
@kikoruiz
refactor(packages/sui-i18n): apply new linting rules
a5d8505
@kikoruiz
refactor(packages/sui-jest): apply new linting rules
f95d40b
@kikoruiz
refactor(packages/sui-js-compiler): apply new linting rules
b15581f
@kikoruiz
refactor(packages/sui-js): apply new linting rules
237bbf5
@kikoruiz
refactor(packages/sui-lint): apply new linting rules
53b302f
@kikoruiz
refactor(packages/sui-mock): apply new linting rules
51b346b
@kikoruiz
refactor(packages/sui-mockmock): apply new linting rules
d58f859
@kikoruiz
refactor(packages/sui-mono): apply new linting rules
231374c
@kikoruiz
refactor(packages/sui-pde): apply new linting rules
032f614
@kikoruiz
refactor(packages/sui-polyfills): apply new linting rules
b9affc1
@kikoruiz
refactor(packages/sui-precommit): apply new linting rules
405084e
@kikoruiz
refactor(packages/sui-react-head): apply new linting rules
44f605e
@kikoruiz
refactor(packages/sui-react-router): apply new linting rules
af61431
@kikoruiz
refactor(packages/sui-react-web-vitals): apply new linting rules
93ad8aa
@kikoruiz
refactor(packages/sui-sass-loader): apply new linting rules
f24b814
@kikoruiz
refactor(packages/sui-ssr): apply new linting rules
f06fab7
@kikoruiz
refactor(packages/sui-studio-create): apply new linting rules
51631a9
@kikoruiz
refactor(packages/sui-studio-utils): apply new linting rules
f3dc347
@jordevo
Copy link
Contributor

jordevo commented Nov 21, 2023

could've been a chore type of commit in order to skip the triggering of all the packages' releases...

@kikoruiz kikoruiz changed the title apply new linting rules [REFACTOR] apply new linting rules Nov 21, 2023
@kikoruiz
Copy link
Member Author

kikoruiz commented Nov 21, 2023 •
edited
Loading

could've been a chore type of commit in order to skip the triggering of all the packages' releases...

@jordevo Not sure about this fact... the only thing I know is this one will be funnier 😆

Anyway, I've created another one with chore type on all the commits: #1666, so we can choose.

@andresz1
Copy link
Member

andresz1 commented Nov 22, 2023 •
edited
Loading

could've been a chore type of commit in order to skip the triggering of all the packages' releases...

I agree with @jordevo Perhaps we should close this one then ?

@kikoruiz kikoruiz closed this Nov 22, 2023
@kikoruiz kikoruiz deleted the new-linting-rules branch November 22, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AgonisticKatai AgonisticKatai AgonisticKatai approved these changes

@jordevo jordevo jordevo approved these changes

@nucliweb nucliweb nucliweb approved these changes

@sui-bot sui-bot Awaiting requested review from sui-bot sui-bot is a code owner

@andresz1 andresz1 Awaiting requested review from andresz1 andresz1 is a code owner

@carlosvillu carlosvillu Awaiting requested review from carlosvillu carlosvillu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kikoruiz @jordevo @andresz1 @nucliweb @AgonisticKatai