[REFACTOR] apply new linting rules

packages/babel-preset-sui/src/index.js

@@ -1,17 +1,10 @@
-const {
-  DEFAULT_LEGACY_BROWSER_TARGETS,
-  DEFAULT_BROWSER_TARGETS,
-  DEFAULT_SERVER_TARGETS
-} = require('./defaults.js')
+const {DEFAULT_LEGACY_BROWSER_TARGETS, DEFAULT_BROWSER_TARGETS, DEFAULT_SERVER_TARGETS} = require('./defaults.js')
 
 const getTargets = ({targets = {}, isModern, isServer}) => {
   const {server, browser} = targets
   if (isModern && isServer) return server ?? DEFAULT_SERVER_TARGETS
 
-  return (
-    browser ??
-    (isModern ? DEFAULT_BROWSER_TARGETS : DEFAULT_LEGACY_BROWSER_TARGETS)
-  )
+  return browser ?? (isModern ? DEFAULT_BROWSER_TARGETS : DEFAULT_LEGACY_BROWSER_TARGETS)
 }
 
 const plugins = (api, {useESModules = true} = {}) => [
@@ -47,10 +40,7 @@ const presets = (api, opts = {}) => {
         useBuiltIns: false
       }
     ],
-    [
-      require('@babel/preset-react').default,
-      {runtime: 'automatic', useBuiltIns: true}
-    ]
+    [require('@babel/preset-react').default, {runtime: 'automatic', useBuiltIns: true}]
   ]
 }
 

packages/sui-bundler/bin/sui-bundler-build.js

@@ -41,12 +41,7 @@ program
   })
   .parse(process.argv)
 
-const {
-  clean = false,
-  context,
-  saveStats,
-  linkPackage: packagesToLink = []
-} = program.opts()
+const {clean = false, context, saveStats, linkPackage: packagesToLink = []} = program.opts()
 
 config.context = context || config.context
 
@@ -106,10 +101,7 @@ compiler.run(async (error, stats) => {
   const resolvePublicFile = file => path.resolve(process.cwd(), 'public', file)
 
   if (offlinePageExists) {
-    fs.copyFileSync(
-      path.resolve(offlinePath),
-      resolvePublicFile('offline.html')
-    )
+    fs.copyFileSync(path.resolve(offlinePath), resolvePublicFile('offline.html'))
   }
 
   if (offlinePageExists || staticsCacheOnly) {
@@ -126,41 +118,27 @@ compiler.run(async (error, stats) => {
 
     const importScripts = offlineConfig.importScripts || []
 
-    const stringImportScripts = importScripts
-      .map(url => `importScripts("${url}")`)
-      .join('\n')
+    const stringImportScripts = importScripts.map(url => `importScripts("${url}")`).join('\n')
 
-    Boolean(importScripts.length) &&
-      console.log('\nExternal Scripts Added to the SW:\n', stringImportScripts)
+    Boolean(importScripts.length) && console.log('\nExternal Scripts Added to the SW:\n', stringImportScripts)
 
     // read the service worker template
-    const swTemplate = fs.readFileSync(
-      path.resolve(__dirname, '..', 'service-worker.js'),
-      'utf-8'
-    )
+    const swTemplate = fs.readFileSync(path.resolve(__dirname, '..', 'service-worker.js'), 'utf-8')
 
     // replace all the variables from the template with the actual values
     const swCode = swTemplate
       .replace('// IMPORT_SCRIPTS_HERE', stringImportScripts)
       .replace("require('static-manifest')", JSON.stringify(manifestStatics))
-      .replace(
-        "require('static-cache-name')",
-        JSON.stringify(Date.now().toString())
-      )
-      .replace(
-        "require('static-statics-cache-only')",
-        JSON.stringify(staticsCacheOnly)
-      )
+      .replace("require('static-cache-name')", JSON.stringify(Date.now().toString()))
+      .replace("require('static-statics-cache-only')", JSON.stringify(staticsCacheOnly))
 
     const swFilePath = resolvePublicFile('service-worker.js')
 
     await writeFile(swFilePath, swCode)
     console.log('\nService worker generated succesfully!\n')
   }
 
-  log.success(
-    `Your app is compiled in ${process.env.NODE_ENV} mode in /public. It's ready to roll!`
-  )
+  log.success(`Your app is compiled in ${process.env.NODE_ENV} mode in /public. It's ready to roll!`)
 
   compiler.close(closeErr => {
     const exitCode = closeErr ? 1 : 0

packages/sui-bundler/bin/sui-bundler-dev.js

@@ -28,10 +28,7 @@ const DEFAULT_WATCH = !CI
 if (!module.parent) {
   program
     .option('-c, --context [folder]', 'Context folder (cwd by default)')
-    .option(
-      '-L, --link-all [monorepo]',
-      'Link all packages inside of monorepo multipackage'
-    )
+    .option('-L, --link-all [monorepo]', 'Link all packages inside of monorepo multipackage')
     .option(
       '-l, --link-package [package]',
       'Replace each occurrence of this package with an absolute path to this folder',
@@ -41,11 +38,7 @@ if (!module.parent) {
       },
       []
     )
-    .option(
-      '-w, --watch',
-      'Watch files and restart the server on change',
-      DEFAULT_WATCH
-    )
+    .option('-w, --watch', 'Watch files and restart the server on change', DEFAULT_WATCH)
     .on('--help', () => {
       console.log('  Examples:')
       console.log('')
@@ -61,21 +54,11 @@ if (!module.parent) {
   webpackConfig.context = context || webpackConfig.context
 }
 
-const start = async ({
-  config = webpackConfig,
-  packagesToLink = program.opts().linkPackage || []
-} = {}) => {
+const start = async ({config = webpackConfig, packagesToLink = program.opts().linkPackage || []} = {}) => {
   clearConsole()
   // Warn and crash if required files are missing
-  if (
-    !checkRequiredFiles([
-      path.join(config.context, 'index.html'),
-      path.join(config.context, 'app.js')
-    ])
-  ) {
-    log.error(
-      `✖ Required files are missing, create and index.html and app.js inside your src folder.`
-    )
+  if (!checkRequiredFiles([path.join(config.context, 'index.html'), path.join(config.context, 'app.js')])) {
+    log.error(`✖ Required files are missing, create and index.html and app.js inside your src folder.`)
     process.exit(1)
   }
 

packages/sui-bundler/bin/sui-bundler-lib.js

@@ -16,10 +16,7 @@ program
   .option('-o, --output [output]', 'Bundle folder path')
   .option('-u, --umd [libraryName]', 'Whether to output library as umb')
   .option('-r, --root', 'Create build in root dir instead of version subdir')
-  .option(
-    '-p, --path [path]',
-    'Absolute public path where files will be located.'
-  )
+  .option('-p, --path [path]', 'Absolute public path where files will be located.')
   .on('--help', () =>
     console.log(`Examples:
       $ sui-bundler lib src/index.js -o umd/my-lib -p http://my-cdn.com/my-lib -C'
@@ -48,12 +45,7 @@ if (!publicPath) {
 process.env.NODE_ENV = process.env.NODE_ENV || 'production'
 
 const version = getPackageJson(process.cwd()).version
-const outputFolder = path.join(
-  process.cwd(),
-  output,
-  path.sep,
-  root ? '' : version
-)
+const outputFolder = path.join(process.cwd(), output, path.sep, root ? '' : version)
 const webpackConfig = {...config, entry: path.resolve(process.cwd(), entry)}
 webpackConfig.output.publicPath = publicPath + (root ? '' : version + '/')
 webpackConfig.output.path = outputFolder
@@ -94,7 +86,5 @@ webpack(webpackConfig).run((error, stats) => {
   }
 
   console.log(`Webpack stats: ${stats}`)
-  log.success(
-    `Your library is compiled in production mode in: \n${outputFolder}`
-  )
+  log.success(`Your library is compiled in production mode in: \n${outputFolder}`)
 })

packages/sui-bundler/bin/sui-bundler.js

@@ -9,9 +9,6 @@ program
   .command('dev', 'open a server dev to start the development')
   .command('build', 'Compile all assets and create a public folder')
   .command('lib', 'Compile a library to a bundle with chunks.')
-  .command(
-    'analyzer',
-    'Compile all assets and create a HTML inspector for your bundle'
-  )
+  .command('analyzer', 'Compile all assets and create a HTML inspector for your bundle')
 
 program.parse(process.argv)

packages/sui-bundler/example/src/app.js

@@ -4,11 +4,9 @@ import {render} from 'react-dom'
 import Hello from './hello.js'
 
 // eslint-next-disable-line
-import(/* webpackChunkName: "my-chunk-name" */ './foo.js').then(
-  ({default: foo}) => {
-    console.log('loaded async chunk')
-    foo()
-  }
-)
+import(/* webpackChunkName: "my-chunk-name" */ './foo.js').then(({default: foo}) => {
+  console.log('loaded async chunk')
+  foo()
+})
 
 render(<Hello />, document.getElementById('root'))

packages/sui-bundler/factories/createCompiler.js

@@ -32,9 +32,7 @@ module.exports = (config, urls) => {
 
     // Log the correct message of compilation depending if we have warnings
     if (isSuccessful) {
-      stats.hasWarnings()
-        ? log.warn('⚠ Compiled with warnings')
-        : log.success('✔ Compiled successfully')
+      stats.hasWarnings() ? log.warn('⚠ Compiled with warnings') : log.success('✔ Compiled successfully')
     }
 
     // Even with warnings, we show instructions to access localhost if we have a compilation
@@ -52,9 +50,7 @@ module.exports = (config, urls) => {
 
     // With warnings, even after showing the instructions we must list the warnings we have
     if (stats.hasWarnings()) {
-      const messages = formatWebpackMessages(
-        stats.toJson('errors-warnings', true)
-      )
+      const messages = formatWebpackMessages(stats.toJson('errors-warnings', true))
       log.warn(messages.warnings.join('\n\n'))
     }
   })

packages/sui-bundler/loaders/ExternalsManifestLoader.js

@@ -46,9 +46,7 @@ async function externalsManifestLoader(source) {
 
   try {
     const manifest = await getRemoteManifest(
-      typeof manifestURL === 'string'
-        ? manifestURL
-        : manifestURL[process.env.NODE_ENV]
+      typeof manifestURL === 'string' ? manifestURL : manifestURL[process.env.NODE_ENV]
     )
     const entries = Object.entries(manifest)
     const nextSource = entries.reduce((acc, entry) => {

packages/sui-bundler/loaders/linkLoaderConfigBuilder.js

@@ -14,21 +14,15 @@ const diccFromAbsolutePaths = (paths, init = {}) =>
       log.success(`✔ ${pkg.name} from path "${packagePath}"`)
       return acc
     } catch (e) {
-      log.warn(
-        `⚠ Package from path "${packagePath}" can't be linked.\n  Path is wrong or package.json is missing.`
-      )
+      log.warn(`⚠ Package from path "${packagePath}" can't be linked.\n  Path is wrong or package.json is missing.`)
       return acc
     }
   }, init)
 
 const absolutePathForMonoRepo = base => {
   if (!base) return []
   return fg
-    .sync([
-      `${path.resolve(base)}/**/package.json`,
-      '!**/node_modules/**',
-      '!**/lib/**'
-    ])
+    .sync([`${path.resolve(base)}/**/package.json`, '!**/node_modules/**', '!**/lib/**'])
     .map(p => path.dirname(p))
 }
 

packages/sui-bundler/loaders/sassLinkImporter.js

@@ -8,10 +8,7 @@ const createSassLinkImporter = entryPoints => url => {
     const [org, name] = url.split(/\//)
     const pkg = [org.replace('~', ''), name].join('/')
 
-    const absoluteUrl = url.replace(
-      new RegExp(`~?${pkg}(\\/lib)?`, 'g'),
-      entryPoints[pkg]
-    )
+    const absoluteUrl = url.replace(new RegExp(`~?${pkg}(\\/lib)?`, 'g'), entryPoints[pkg])
     return {file: absoluteUrl}
   }
   return null

packages/sui-bundler/service-worker.js

@@ -50,9 +50,7 @@ const copyResponse = async function (response) {
     statusText: clonedResponse.statusText
   }
 
-  const body = canConstructResponseFromBodyStream()
-    ? clonedResponse.body
-    : await clonedResponse.blob()
+  const body = canConstructResponseFromBodyStream() ? clonedResponse.body : await clonedResponse.blob()
 
   return new Response(body, responseInit)
 }

packages/sui-bundler/shared/config.js

@@ -1,14 +1,8 @@
 /* Extract sui-bundler from package.json -> "config": {"sui-bundler": { ... }} */
-const {
-  config: packageJsonConfig = {}
-} = require(`${process.cwd()}/package.json`)
+const {config: packageJsonConfig = {}} = require(`${process.cwd()}/package.json`)
 
 const {'sui-bundler': config = {}} = packageJsonConfig
-const {
-  extractComments = false,
-  sourcemaps,
-  supportLegacyBrowsers = true
-} = config
+const {extractComments = false, sourcemaps, supportLegacyBrowsers = true} = config
 
 exports.config = config
 exports.supportLegacyBrowsers = supportLegacyBrowsers

packages/sui-bundler/shared/inline-chunk-html-plugin.js

@@ -19,9 +19,7 @@ class InlineChunkHtmlPlugin {
     if (tag.tagName !== 'script' || !(tag.attributes && tag.attributes.src)) {
       return tag
     }
-    const scriptName = publicPath
-      ? tag.attributes.src.replace(publicPath, '')
-      : tag.attributes.src
+    const scriptName = publicPath ? tag.attributes.src.replace(publicPath, '') : tag.attributes.src
     if (!this.tests.some(test => scriptName.match(test))) {
       return tag
     }
@@ -39,8 +37,7 @@ class InlineChunkHtmlPlugin {
     }
 
     compiler.hooks.compilation.tap('InlineChunkHtmlPlugin', compilation => {
-      const tagFunction = tag =>
-        this.getInlinedTag(publicPath, compilation.assets, tag)
+      const tagFunction = tag => this.getInlinedTag(publicPath, compilation.assets, tag)
 
       const hooks = this.htmlWebpackPlugin.getHooks(compilation)
       hooks.alterAssetTagGroups.tap('InlineChunkHtmlPlugin', assets => {

packages/sui-bundler/shared/minify-js.js

@@ -22,6 +22,4 @@ const terserMinifier = ({extractComments, sourceMap}) =>
   })
 
 module.exports = ({extractComments, sourceMap}) =>
-  supportLegacyBrowsers
-    ? terserMinifier({extractComments, sourceMap})
-    : esbuildMinifier({sourceMap})
+  supportLegacyBrowsers ? terserMinifier({extractComments, sourceMap}) : esbuildMinifier({sourceMap})

packages/sui-bundler/shared/module-rules-babel.js

@@ -5,11 +5,7 @@ const EXCLUDED_FOLDERS_REGEXP = new RegExp(
   `node_modules(?!${path.sep}@s-ui(${path.sep}studio)(${path.sep}workbench)?${path.sep}src)`
 )
 
-module.exports = ({
-  isServer = false,
-  isDevelopment = false,
-  supportLegacyBrowsers = true
-} = {}) => ({
+module.exports = ({isServer = false, isDevelopment = false, supportLegacyBrowsers = true} = {}) => ({
   test: /\.jsx?$/,
   exclude: EXCLUDED_FOLDERS_REGEXP,
   use: [
@@ -20,9 +16,7 @@ module.exports = ({
         cacheCompression: false,
         babelrc: false,
         compact: true,
-        plugins: [
-          isDevelopment && require.resolve('react-refresh/babel')
-        ].filter(Boolean),
+        plugins: [isDevelopment && require.resolve('react-refresh/babel')].filter(Boolean),
         presets: [
           [
             require.resolve('babel-preset-sui'),