-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(packages/sui-pde): upgrade optimizely version and add use-decisi… #1824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nucliweb
reviewed
Sep 26, 2024
/** | ||
* @param {object} param | ||
* @param {string} param.name | ||
* @param {object} param.attributes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
* @param {object} param.attributes | |
* @param {object} param.attributes | |
* @param {string} param.adapterId |
andresz1
requested review from
sui-bot,
kikoruiz and
carlosvillu
as code owners
October 2, 2024 10:13
nucliweb
approved these changes
Oct 2, 2024
AgonisticKatai
approved these changes
Oct 2, 2024
javiauso
reviewed
Oct 2, 2024
@@ -1,3 +1,3 @@ | |||
import './pdeSpec.js' | |||
import './useExperimentSpec' // This file has no extension due to sui-test server problem | |||
import './useExperimentSpec.js' // This file has no extension due to sui-test server problem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now seems that the comment could be removed
javiauso
approved these changes
Oct 2, 2024
kikoruiz
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces Feature Tests.
Feature tests are similar to A/B/n tests that allow you to control whether for each variation the associated feature is on or off via feature flags (aka feature toggles). It also allows you to control the feature variable values for the various variables associated with the feature.
The
useDecision
hook retrieves the result for a given decision, based on logic from the decision-making tool you are using (e.g., Optimizely).You can also use the
Decision
component: