-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(packages/sui-pde): upgrade optimizely version and add use-decisi… #1824
Merged
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
1634c34
feat(packages/sui-pde): upgrade optimizely version and add use-decisi…
andresz1 ecbb326
feat(packages/sui-pde): update usedecision hook
andresz1 2b86724
feat(packages/sui-pde): add decision component
andresz1 e00f881
feat(packages/sui-pde): update doc
andresz1 ac678bd
feat(packages/sui-pde): update use decision hook
andresz1 d8b892f
test(packages/sui-pde): update tests
andresz1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
import {useContext, useMemo} from 'react' | ||
|
||
import PdeContext from '../contexts/PdeContext.js' | ||
import {getPlatformStrategy} from './common/platformStrategies.js' | ||
|
||
/** | ||
* Hook to use a feature test | ||
* @param {string} name | ||
* @param {object} param | ||
* @param {object} param.attributes | ||
* @param {function} param.trackExperimentViewed | ||
* @param {string} param.queryString | ||
* @param {string} param.adapterId Adapter id to be executed | ||
* @return {object} | ||
*/ | ||
export default function useDecision(name, {attributes, trackExperimentViewed, queryString, adapterId} = {}) { | ||
const {pde} = useContext(PdeContext) | ||
|
||
if (pde === null) { | ||
throw new Error('[sui-pde: useDecision] sui-pde provider is required to work') | ||
} | ||
|
||
const variation = useMemo(() => { | ||
const strategy = getPlatformStrategy({ | ||
customTrackExperimentViewed: trackExperimentViewed | ||
}) | ||
|
||
const forced = strategy.getForcedValue({ | ||
key: name, | ||
queryString | ||
}) | ||
|
||
const data = strategy.decide({ | ||
pde, | ||
name, | ||
attributes, | ||
adapterId | ||
}) | ||
|
||
const {ruleKey, variationKey} = data || {} | ||
|
||
if (forced) { | ||
if (!ruleKey) { | ||
return {...data, enabled: forced === 'on'} | ||
} | ||
|
||
return {...data, enabled: true, variationKey: forced} | ||
} | ||
|
||
if (ruleKey) { | ||
strategy.trackExperiment({variationName: variationKey, experimentName: name}) | ||
} | ||
|
||
return data | ||
}, [trackExperimentViewed, name, queryString, pde, attributes, adapterId]) | ||
|
||
return {variation} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.