fix request() for method and url to be keyword args, not just positional
#21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yword arguments, not just positional arguments
|
Hi @paulie4, thanks for the PR! There is a similar fix included in the feature/use-requests-oauthlib-1.3 branch of this repo (it includes bulk api v1 query support too). Can you try that branch and see if it gets you what you need? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
request()broke whenrequests-oauthlibmade this change, where they started callingrequest()usingmethod=method, url=token_urlas keyword arguments instead of positional arguments, so this change fixes it.