Added Satellite Capsule page coverage #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LadislavVasina1
added
entity
pondrejk
approved these changes
Nov 30, 2023
| view = CreateCapsuleView(self.browser) | ||
| view.fill(values) | ||
| view.submit.click() | ||
| view = CapsulesView(self.browser) |
There was a problem hiding this comment.
Is there a reason for reassigning the view variable here? Maybe there is, just seems puzzling to me, especially if we are not returning it
There was a problem hiding this comment.
From my experience, it's better when this type of entity ends with the same view as it started for better usage of multiple entities.
LadislavVasina1
force-pushed
the
capsules_coverage_615
branch
from
ae89a59 to
0755931
Compare
vsedmik
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
LGTM, tested locally and works like a magic.
Also used by SatelliteQE/robottelo#13351
github-actions bot
pushed a commit
that referenced
this pull request
Dec 8, 2023
* Added Satellite Capsule page coverage * Precommit ran * precommit2 * Added entities for capusle syncing * Added entity enabling refresh of lce counts * Added some entities * Added code to read sync status icon (cherry picked from commit 8322495)
vsedmik
pushed a commit
that referenced
this pull request
Dec 13, 2023
* Added Satellite Capsule page coverage * Precommit ran * precommit2 * Added entities for capusle syncing * Added entity enabling refresh of lce counts * Added some entities * Added code to read sync status icon (cherry picked from commit 8322495) Co-authored-by: Ladislav Vašina <[email protected]>
damoore044
pushed a commit
to damoore044/airgun
that referenced
this pull request
Jan 12, 2024
* Added Satellite Capsule page coverage * Precommit ran * precommit2 * Added entities for capusle syncing * Added entity enabling refresh of lce counts * Added some entities * Added code to read sync status icon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I have added views and entities for Satellite page coverage.