Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UI test for Capsule Content Counts #13351

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Add UI test for Capsule Content Counts #13351

merged 1 commit into from
Dec 15, 2023

Conversation

vsedmik
Copy link
Contributor

@vsedmik vsedmik commented Dec 8, 2023

Problem Statement

UI coverage for Capsule Content Counts (new in 6.15) is missing.

Solution

This PR.

Related Issues

requires SatelliteQE/airgun#1050

@vsedmik vsedmik added UI Issues and PRs involving the UI CherryPick PR needs CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master 6.15.z Introduced in or relating directly to Satellite 6.15 labels Dec 8, 2023
@vsedmik vsedmik self-assigned this Dec 8, 2023
@vsedmik vsedmik requested a review from a team as a code owner December 8, 2023 15:00
@vsedmik
Copy link
Contributor Author

vsedmik commented Dec 8, 2023

trigger: test-robottelo
pytest: tests/foreman/ui/test_capsulecontent.py
airgun: 1050

@vsedmik vsedmik mentioned this pull request Dec 8, 2023
Merged
sambible
sambible approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@sambible sambible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve after discussion with @vsedmik explaining that the commented assertions are due to bugs or missing work. They will be uncommented when that hits downstream.

synkd
synkd approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@synkd synkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, with one non-blocking typo correction.

tests/foreman/ui/test_capsulecontent.py Outdated

for s_repo in sat_repos:
c_repo = next(r for r in repos_details if r[0] == s_repo.name)
assert c_repo, 'Reposiory not listed'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
assert c_repo, 'Reposiory not listed'
assert c_repo, 'Repository not listed'

pondrejk
pondrejk approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@pondrejk pondrejk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack, pending typo

@vsedmik
Copy link
Contributor Author

vsedmik commented Dec 13, 2023

resolved typo, rebased

@pondrejk pondrejk merged commit e77ef86 into SatelliteQE:master Dec 15, 2023
5 checks passed
@Satellite-QE Satellite-QE mentioned this pull request Dec 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@synkd synkd synkd approved these changes

@sambible sambible sambible approved these changes

@pondrejk pondrejk pondrejk approved these changes

Assignees

@vsedmik vsedmik

Labels
6.15.z Introduced in or relating directly to Satellite 6.15 CherryPick PR needs CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master UI Issues and PRs involving the UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vsedmik @pondrejk @sambible @synkd