Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.13.z] Add coverage for 1964037 installer cert regeneration #12800

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #12776

The changes to base.py are also in another one of my PR's (#12756). Simple test here to make sure cert regeneration works when the change is made to the answers file. Also providing coverage for certs-regenerate since we don't have any tests for that.

@Satellite-QE Satellite-QE added 6.13.z Introduced in or relating directly to Satellite 6.13 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Oct 3, 2023
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/destructive/test_installer.py::test_positive_installer_certs_regenerate

@Satellite-QE Satellite-QE added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Oct 3, 2023
@Griffin-Sullivan
Copy link
Contributor

Failed because another PR that was merged has the code changes needed for this one, but the cherry-pick for that was not merged due to a PRT failure.

@Griffin-Sullivan
Copy link
Contributor

trigger: test-robottelo
pytest: tests/foreman/destructive/test_installer.py::test_positive_installer_certs_regenerate

@Griffin-Sullivan Griffin-Sullivan force-pushed the cherry-pick-6.13.z-8d98645c4b53b53d0f983a0752506c8fa3fa5db7 branch from 7199398 to 204656f Compare October 5, 2023 16:40
@Griffin-Sullivan
Copy link
Contributor

trigger: test-robottelo
pytest: tests/foreman/destructive/test_installer.py::test_positive_installer_certs_regenerate

@Griffin-Sullivan Griffin-Sullivan marked this pull request as ready for review October 5, 2023 17:51
@Satellite-QE Satellite-QE merged commit 7447295 into 6.13.z Oct 5, 2023
7 checks passed
@Satellite-QE Satellite-QE deleted the cherry-pick-6.13.z-8d98645c4b53b53d0f983a0752506c8fa3fa5db7 branch October 5, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.13.z Introduced in or relating directly to Satellite 6.13 Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants