Add a mechanism to swap nailgun versions on demand #12840
Conversation
Satellite._swap_nailgun("x.y.z") can be used to change out the operating
version of nailgun.
JacobCallahan
added
enhancement
| to_clear = [k for k in sys.modules.keys() if 'nailgun' in k] | ||
| [sys.modules.pop(k) for k in to_clear] |
There was a problem hiding this comment.
Does this clearance should be done after uninstalling the previous Nailgun version and before installing new nailgun version ?
There was a problem hiding this comment.
This implementation would likely cleanup the bits of newly installed nailgun as well hence above comment, correct me if I am wrong .
There was a problem hiding this comment.
the order here is less important than you might think. the current modules are live in memory, so this only really helps for new imports (like what we do when recreating the Satellite.api attributes.
There was a problem hiding this comment.
Interesting how popping out the nailgun specific modules from sys.modules would still make nailgun module available.
Do you mean the newly installed nailgun isnt the part of sys.modules and only unistalled is ?
| to_clear = [k for k in sys.modules.keys() if 'nailgun' in k] | ||
| [sys.modules.pop(k) for k in to_clear] |
There was a problem hiding this comment.
Interesting how popping out the nailgun specific modules from sys.modules would still make nailgun module available.
Do you mean the newly installed nailgun isnt the part of sys.modules and only unistalled is ?
|
@jyejare re:
Until a module is loaded via an import statement, it won't be added to |
Satellite._swap_nailgun("x.y.z") can be used to change out the operating version of nailgun.
This actually changes out the installed version of nailgun on the fly, so this should only be used in upgrades.