Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.15 RFE] Prepare users for SCA-ONLY Hammer #12963

Conversation

ColeHiggins2
Copy link
Member

6.15 Features automation: SAT-20202

This test is verifying that hammer notifies users that Simple Content Access will be required for all organizations in Satellite 6.16

As of now, Stream Satellite is showing Katello 4.12 instead of Satellite 6.16. Keeping in Draft state until changes are made

@ColeHiggins2 ColeHiggins2 added RFE Issues that are requesting an enhancement to robottelo CLI Issues and PRs involving the CLI No-CherryPick PR doesnt need CherryPick to previous branches labels Oct 23, 2023
@ColeHiggins2 ColeHiggins2 self-assigned this Oct 23, 2023
@ColeHiggins2 ColeHiggins2 requested a review from a team as a code owner October 23, 2023 19:22
@ColeHiggins2 ColeHiggins2 marked this pull request as draft October 23, 2023 19:22
@ColeHiggins2 ColeHiggins2 marked this pull request as ready for review November 27, 2023 20:32
@ColeHiggins2 ColeHiggins2 force-pushed the prepare_for_sca_only_hammer branch from 288aa77 to b2ea517 Compare November 27, 2023 20:36
org_results.stderr
)
sca_results = target_sat.execute(
f'hammer simple-content-access disable --organization-id {function_org.id}'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update it to use robottelo cli method SimpleContentAccess.disable()?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ColeHiggins2 as you need to verify output from command's stderr, and you're not able to use cli.SimpleContentAccess for this because of ignore_stderr=True argument, you could remove it from here and update the PR for the same https://github.com/SatelliteQE/robottelo/blob/master/robottelo/cli/simple_content_access.py#L33

will be required for all organizations in Satellite 6.16
"""
org_results = target_sat.execute(
f'hammer organization update --id {function_org.id} --simple-content-access false'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@Gauravtalreja1
Copy link
Collaborator

@ColeHiggins2 As 6.15.z branching is done already, you'll need to cherrypick this to 6.15.z and flip the labels on this PR

@ColeHiggins2
Copy link
Member Author

Waiting on dev to verify hammer fix. do not merge until confirmed

@ColeHiggins2
Copy link
Member Author

ColeHiggins2 commented Nov 30, 2023

waiting for downstream snap for foreman_theme_satellite packages to be applied to merge

Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also get/assert that warning on CREATE operation?

hammer organization create --name OWCA --simple-content-access False

@jyejare
Copy link
Member

jyejare commented Jan 2, 2024

@ColeHiggins2 Moving this to draft state as per your last comments! Please remove the from draft when its ready to merge !

@jyejare jyejare marked this pull request as draft January 2, 2024 08:35
Copy link
Member

@jyejare jyejare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with a non-blocking comment !

org_results = target_sat.execute(
f'hammer organization update --id {function_org.id} --simple-content-access false'
)
assert 'Simple Content Access will be required for all organizations in Satellite 6.16' in str(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
assert 'Simple Content Access will be required for all organizations in Satellite 6.16' in str(
assert 'Simple Content Access will be required for all organizations in Satellite' in str(

Could we eliminate satellite version so that it won't fail in the future due to version change in the string ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI Issues and PRs involving the CLI No-CherryPick PR doesnt need CherryPick to previous branches RFE Issues that are requesting an enhancement to robottelo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants