-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[6.15 RFE] Prepare users for SCA-ONLY Hammer #12963
[6.15 RFE] Prepare users for SCA-ONLY Hammer #12963
Conversation
288aa77
to
b2ea517
Compare
org_results.stderr | ||
) | ||
sca_results = target_sat.execute( | ||
f'hammer simple-content-access disable --organization-id {function_org.id}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we update it to use robottelo cli method SimpleContentAccess.disable()
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ColeHiggins2 as you need to verify output from command's stderr, and you're not able to use cli.SimpleContentAccess for this because of ignore_stderr=True argument, you could remove it from here and update the PR for the same https://github.com/SatelliteQE/robottelo/blob/master/robottelo/cli/simple_content_access.py#L33
will be required for all organizations in Satellite 6.16 | ||
""" | ||
org_results = target_sat.execute( | ||
f'hammer organization update --id {function_org.id} --simple-content-access false' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
@ColeHiggins2 As 6.15.z branching is done already, you'll need to cherrypick this to 6.15.z and flip the labels on this PR |
Waiting on dev to verify hammer fix. do not merge until confirmed |
waiting for downstream snap for foreman_theme_satellite packages to be applied to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also get/assert that warning on CREATE operation?
hammer organization create --name OWCA --simple-content-access False
@ColeHiggins2 Moving this to draft state as per your last comments! Please remove the from draft when its ready to merge ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with a non-blocking comment !
org_results = target_sat.execute( | ||
f'hammer organization update --id {function_org.id} --simple-content-access false' | ||
) | ||
assert 'Simple Content Access will be required for all organizations in Satellite 6.16' in str( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assert 'Simple Content Access will be required for all organizations in Satellite 6.16' in str( | |
assert 'Simple Content Access will be required for all organizations in Satellite' in str( |
Could we eliminate satellite version so that it won't fail in the future due to version change in the string ?
b2ea517
to
658c766
Compare
6.15 Features automation: SAT-20202
This test is verifying that hammer notifies users that Simple Content Access will be required for all organizations in Satellite 6.16
As of now, Stream Satellite is showing
Katello 4.12
instead ofSatellite 6.16
. Keeping in Draft state until changes are made