-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[6.15] negative test for webhook task #13049
Conversation
@jameerpathan111 changes committed, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where are we asserting that the task failed? Also are you able to get local results with a packit installed stream Satellite?
48c7344
to
9d7026a
Compare
|
@Griffin-Sullivan yeah it's kind of buried, the must_succeed=False parameter tells wait_for_task to assert failure
|
9d7026a
to
0e64acd
Compare
trigger: test-robottelo |
trigger: test-robottelo |
1 similar comment
trigger: test-robottelo |
0e64acd
to
7eb7388
Compare
7eb7388
to
78c7ae5
Compare
trigger: test-robottelo |
@Griffin-Sullivan @jameerpathan111 the thing landed in stream, prt now passes |
negative test for webhook task (cherry picked from commit 37da211)
negative test for webhook task (cherry picked from commit 37da211)
negative test for webhook task
Problem Statement
The "Deliver webhook..." task for the triggered hook previously succeeded even If the webhook execution failed for some reason. This will change in 6.15
Solution
I'm adding a negative test to cover this scenario. Note that the upstream PR isn't merged yet, so prt trigger would fail atm
Related Issues
SAT-21112