Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stream fix for e2e api http_proxy failure #13064

Merged
merged 3 commits into from
Nov 16, 2023
Merged

Conversation

damoore044
Copy link
Contributor

@damoore044 damoore044 commented Nov 8, 2023

This test already passes locally, but fails for the auth and unauth-proxy parameters in CI.
HTTPError 500: Internal Server Error: {"displayMessage":"Task {taks_id}: RuntimeError: The repository's publication is missing. Please run a 'complete sync' on repo_name."

There seems to be a delay after create(), where the Metadata Generate tasks is still in progress when calling repo.update(). To resolve I have the repos wait for a sync before continuing, which in theory would wait for any in-progress metadata task.

@damoore044 damoore044 added No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Nov 8, 2023
@damoore044

This comment was marked as duplicate.

@damoore044

This comment was marked as duplicate.

@damoore044 damoore044 marked this pull request as ready for review November 8, 2023 22:53
@damoore044 damoore044 requested a review from a team as a code owner November 8, 2023 22:53
@damoore044 damoore044 requested a review from vsedmik November 8, 2023 22:54
@damoore044 damoore044 added the Easy Fix :) Easiest Fix to review and quick merge request. label Nov 8, 2023
Copy link
Contributor

@adarshdubey-star adarshdubey-star left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@damoore044

This comment was marked as duplicate.

1 similar comment
@damoore044

This comment was marked as duplicate.

@damoore044 damoore044 changed the title Test fix for stream http_proxy failure Stream fix for e2e api http_proxy failure Nov 9, 2023
@damoore044

This comment was marked as duplicate.

@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_http_proxy.py -k test_positive_end_to_end

@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_http_proxy.py -k test_positive_end_to_end

1 similar comment
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_http_proxy.py -k test_positive_end_to_end

Copy link
Member

@ColeHiggins2 ColeHiggins2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack Looks good to me!

@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_http_proxy.py -k test_positive_end_to_end

2 similar comments
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_http_proxy.py -k test_positive_end_to_end

@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_http_proxy.py -k test_positive_end_to_end

@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_http_proxy.py -k test_positive_end_to_end

Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one non-blocking nitpick. And PRT pending.

tests/foreman/api/test_http_proxy.py Outdated Show resolved Hide resolved
tests/foreman/api/test_http_proxy.py Show resolved Hide resolved
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_http_proxy.py -k test_positive_end_to_end

@vsedmik vsedmik added CherryPick PR needs CherryPick to previous branches 6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 and removed No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Nov 16, 2023
@vsedmik vsedmik merged commit 6e804fa into SatelliteQE:master Nov 16, 2023
11 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 16, 2023
* Stream fix for e2e http_proxy failure

* Lastest prt failure, now seeing same issue with rh_repo

* Repo discovery fix

(cherry picked from commit 6e804fa)
github-actions bot pushed a commit that referenced this pull request Nov 16, 2023
* Stream fix for e2e http_proxy failure

* Lastest prt failure, now seeing same issue with rh_repo

* Repo discovery fix

(cherry picked from commit 6e804fa)
github-actions bot pushed a commit that referenced this pull request Nov 16, 2023
* Stream fix for e2e http_proxy failure

* Lastest prt failure, now seeing same issue with rh_repo

* Repo discovery fix

(cherry picked from commit 6e804fa)
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
* Stream fix for e2e http_proxy failure

* Lastest prt failure, now seeing same issue with rh_repo

* Repo discovery fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 CherryPick PR needs CherryPick to previous branches Easy Fix :) Easiest Fix to review and quick merge request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants