-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First tests for new All Hosts page #13120
Conversation
ca94098
to
be6646d
Compare
830ec56
to
1674104
Compare
trigger: test-robottelo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one non-blocking suggestion to consider.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding more comments related to assertion which would help to check existance of host.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack pending comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack
@sambible please resolve the conflicts. |
984a9c5
to
d50d2aa
Compare
This is testing the first set of features for the new All Hosts page. Currently this only includes the Bulk Delete feature, as well as bulk content source change. This PR includes tests for delete and bulk delete, as the Content Source change feature is something with no current coverage, despite being introduced in 6.12
This is a gap I'll look to address in the future in a seperate PR, as part of ongoing coverage increases.
Requires:
trigger: test-robottelo
airgun: 1039
pytest: tests/foreman/ui/test_host.py -k 'test_all_hosts_delete'