Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First tests for new All Hosts page #13120

Merged
merged 3 commits into from
Nov 27, 2023

Conversation

sambible
Copy link
Contributor

This is testing the first set of features for the new All Hosts page. Currently this only includes the Bulk Delete feature, as well as bulk content source change. This PR includes tests for delete and bulk delete, as the Content Source change feature is something with no current coverage, despite being introduced in 6.12

This is a gap I'll look to address in the future in a seperate PR, as part of ongoing coverage increases.
Requires:

trigger: test-robottelo
airgun: 1039
pytest: tests/foreman/ui/test_host.py -k 'test_all_hosts_delete'

@sambible sambible added No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Nov 16, 2023
@sambible sambible self-assigned this Nov 16, 2023
@sambible sambible requested a review from a team as a code owner November 16, 2023 19:47
@sambible
Copy link
Contributor Author

trigger: test-robottelo
airgun: 1039
pytest: tests/foreman/ui/test_host.py -k 'test_all_hosts_delete or test_all_hosts_bulk_delete'

Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one non-blocking suggestion to consider.

tests/foreman/ui/test_host.py Show resolved Hide resolved
Copy link
Contributor

@vijaysawant vijaysawant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding more comments related to assertion which would help to check existance of host.

tests/foreman/ui/test_host.py Show resolved Hide resolved
tests/foreman/ui/test_host.py Show resolved Hide resolved
tests/foreman/ui/test_host.py Show resolved Hide resolved
Copy link
Member

@ColeHiggins2 ColeHiggins2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack pending comments

@sambible sambible requested review from a team November 21, 2023 15:50
Copy link
Contributor

@vijaysawant vijaysawant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@adarshdubey-star
Copy link
Contributor

@sambible please resolve the conflicts.

@sambible sambible merged commit f6e7aff into SatelliteQE:master Nov 27, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants