remove test_installer_inventory_plugin_update #13148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmynar
added
CherryPick
Comment on lines
-115
to
-116
| 'enable-foreman-plugin-rh-cloud', | ||
| foreman_proxy_plugin_remote_execution_script_install_key=['true'], |
There was a problem hiding this comment.
Looking at the description, foreman-plugin-rh-cloud plugun isn't enabled by default, its being enabled during our template process which @jameerpathan111 included iirc, I'd suggest to check with him before removing this test
There was a problem hiding this comment.
It's enabled by default now, we can remove this test and update our template creation code.
# foreman-installer --full-help | grep rh_cloud
--[no-]enable-foreman-plugin-rh-cloud Enable 'foreman_plugin_rh_cloud' puppet module (default: true)```
jameerpathan111
approved these changes
Nov 21, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Nov 21, 2023
(cherry picked from commit c38d4f0)
Gauravtalreja1
pushed a commit
that referenced
this pull request
Nov 22, 2023
remove test_installer_inventory_plugin_update (#13148) (cherry picked from commit c38d4f0) Co-authored-by: rmynar <[email protected]>
shweta83
pushed a commit
to shweta83/robottelo
that referenced
this pull request
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since rh cloud plugin is installed by default (Satellite 6.8) the test does not do what was intended. Original purpose was to change plugin state from disabled to enabled, but it won't change because it's already installed.