Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove test_installer_inventory_plugin_update #13148

Merged
merged 1 commit into from
Nov 21, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 0 additions & 41 deletions tests/foreman/destructive/test_installer.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
from fauxfactory import gen_domain, gen_string
import pytest

from robottelo.config import settings
from robottelo.constants import SATELLITE_ANSWER_FILE
from robottelo.utils.installer import InstallerCommand

Expand Down Expand Up @@ -89,46 +88,6 @@ def test_installer_sat_pub_directory_accessibility(target_sat):
assert 'Success!' in command_output.stdout


def test_installer_inventory_plugin_update(target_sat):
"""DB consistency should not break after enabling the inventory plugin flags

:id: a2b66d38-e819-428f-9529-23bed398c916

:steps:
1. Enable the cloud inventory plugin flag

:expectedresults: inventory flag should be updated successfully without any db consistency
error.

:CaseImportance: High

:CaseLevel: System

:BZ: 1863597

:customerscenario: true

"""
target_sat.create_custom_repos(rhel7=settings.repos.rhel7_os)
installer_cmd = target_sat.install(
InstallerCommand(
'enable-foreman-plugin-rh-cloud',
foreman_proxy_plugin_remote_execution_script_install_key=['true'],
Comment on lines -115 to -116
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the description, foreman-plugin-rh-cloud plugun isn't enabled by default, its being enabled during our template process which @jameerpathan111 included iirc, I'd suggest to check with him before removing this test

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's enabled by default now, we can remove this test and update our template creation code.

# foreman-installer --full-help | grep rh_cloud
    --[no-]enable-foreman-plugin-rh-cloud                                        Enable 'foreman_plugin_rh_cloud' puppet module (default: true)```

)
)
assert 'Success!' in installer_cmd.stdout
verify_rhcloud_flag = target_sat.install(
InstallerCommand(help='|grep "\'foreman_plugin_rh_cloud\' puppet module (default: true)"')
)
assert 'true' in verify_rhcloud_flag.stdout
verify_proxy_plugin_flag = target_sat.install(
InstallerCommand(
**{'full-help': '| grep -A1 foreman-proxy-plugin-remote-execution-script-install-key'}
)
)
assert '(current: true)' in verify_proxy_plugin_flag.stdout


def test_positive_mismatched_satellite_fqdn(target_sat, set_random_fqdn):
"""The satellite-installer should display the mismatched FQDN

Expand Down
Loading