-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix test which addresses katello-host-tools & entitlement_manifest is… #13161
fix test which addresses katello-host-tools & entitlement_manifest is… #13161
Conversation
trigger: test-robottelo |
If the 6.13 and 6.14 failures aren't due to the manifest issues then I would make separate cherry-picks for those and leave this one as is. |
# Get the applicable errata | ||
errata_list = get_applicable_errata(custom_repo) | ||
assert len(errata_list) > 0 | ||
|
||
# Apply incremental update using the first applicable errata | ||
entities.ContentViewVersion().incremental_update( | ||
outval = entities.ContentViewVersion().incremental_update( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should update any use of entities
to target_sat
or module_target_sat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure this suggestion can be done.
fyi.. replacement of entities
with module_target_sat.api
will be taken care by Omkar. So I am not changing non affected part of test module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just two small nitpicks and one question
).create() | ||
# Fetch available subscriptions | ||
subs = entities.Subscription(organization=module_entitlement_manifest_org).search() | ||
subs = entities.Subscription(organization=module_sca_manifest_org).search() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
subs = entities.Subscription(organization=module_sca_manifest_org).search() | |
subs = module_target_sat.api.Subscription(organization=module_sca_manifest_org).search() |
Use sat.api
instead of entities
. But I would say we don't need this kind of check with SCA org.
13a03df
to
e52ce79
Compare
trigger: test-robottelo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Just some nit picks around existing entity
calls in some modified fixtures, we should probably switch those over too?
rhel7_sat6tools_repo = entities.Repository(id=rhel7_sat6tools_repo_id).read() | ||
assert rhel7_sat6tools_repo.sync()['result'] == 'success' | ||
return rhel7_sat6tools_repo | ||
sat_client_repo = entities.Repository(id=sat_client_repo_id).read() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sat_client_repo = entities.Repository(id=sat_client_repo_id).read() | |
sat_client_repo = module_target_sat.api.Repository(id=sat_client_repo_id).read() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, this can be updated
"""Enable custom errata repository""" | ||
custom_repo = entities.Repository( | ||
url=settings.repos.yum_9.url, | ||
product=entities.Product(organization=module_entitlement_manifest_org).create(), | ||
product=entities.Product(organization=module_sca_manifest_org).create(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
product=entities.Product(organization=module_sca_manifest_org).create(), | |
product=module_target_sat.api.Product( | |
organization=module_sca_manifest_org | |
).create(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update
I could change |
e52ce79
to
4abd493
Compare
trigger: test-robottelo |
Problem Statement
Hosts-Content > longrun > increamental update feature test was failing in 6.13.z & 6.14.z because content host unabled to install
katello-host-tools
, also in stream test was failing due to use ofmodule_entitlement_manifest_org
fixtureSolution
Implemented changes which will solve said problem, I am not sure wheather to cherry pick these changes into
6.13.z
&6.14.z