Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eol banner #13211

Merged
merged 1 commit into from
Feb 27, 2024
Merged

eol banner #13211

merged 1 commit into from
Feb 27, 2024

Conversation

pondrejk
Copy link
Contributor

Problem Statement

testing end of life banner

Solution

requires SatelliteQE/airgun#1049

@pondrejk pondrejk requested a review from a team as a code owner November 29, 2023 11:56
@pondrejk pondrejk self-assigned this Nov 29, 2023
@pondrejk pondrejk added 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing labels Nov 29, 2023
@pondrejk
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_eol_banner.py -k test_positive_eol_banner_e2e
airgun: 1049

2 similar comments
@pondrejk
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_eol_banner.py -k test_positive_eol_banner_e2e
airgun: 1049

@pondrejk
Copy link
Contributor Author

pondrejk commented Dec 1, 2023

trigger: test-robottelo
pytest: tests/foreman/ui/test_eol_banner.py -k test_positive_eol_banner_e2e
airgun: 1049

@pondrejk pondrejk force-pushed the eol-banner branch 2 times, most recently from 043d36a to 45cd2d9 Compare December 1, 2023 10:38
@pondrejk
Copy link
Contributor Author

pondrejk commented Dec 1, 2023

trigger: test-robottelo
pytest: tests/foreman/ui/test_eol_banner.py -k test_positive_eol_banner_e2e
airgun: 1049

1 similar comment
@pondrejk
Copy link
Contributor Author

pondrejk commented Dec 4, 2023

trigger: test-robottelo
pytest: tests/foreman/ui/test_eol_banner.py -k test_positive_eol_banner_e2e
airgun: 1049

@pondrejk
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_eol_banner.py -k test_positive_eol_banner_e2e

@pondrejk pondrejk added No-CherryPick PR doesnt need CherryPick to previous branches and removed CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Dec 14, 2023
@pondrejk pondrejk mentioned this pull request Dec 14, 2023
Merged
@lhellebr
Copy link
Contributor

Why no-cheryrpick?

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2024

This pull request has not been updated in the past 45 days.

@github-actions github-actions bot added the Stale Stale issue or Pull Request label Feb 6, 2024
@pondrejk
Copy link
Contributor Author

Hello, please dont't stale it :) This has been merged separately for 6.15 therefore no cherry pick. Atm the version definition on stream builds prevents the banner from working there, so the tests won't pass in this branch. I'll check back with the resolution

@pondrejk pondrejk removed the Stale Stale issue or Pull Request label Feb 12, 2024
@pondrejk
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_eol_banner.py -k test_positive_eol_banner_e2e

1 similar comment
@pondrejk
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_eol_banner.py -k test_positive_eol_banner_e2e

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 5846
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_eol_banner.py -k test_positive_eol_banner_e2e
Test Result : ================= 1 passed, 11 warnings in 1019.86s (0:16:59) ==================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Feb 26, 2024
@pondrejk
Copy link
Contributor Author

This was reviewed and merged as a 6.15 feature in #13463, master was waiting on a code change in stream that is now in, prt passes

@pondrejk pondrejk merged commit d1d8472 into SatelliteQE:master Feb 27, 2024
14 checks passed
@vsedmik vsedmik mentioned this pull request Feb 27, 2024
Merged
This was referenced Feb 27, 2024
Merged
Closed
Closed
@pondrejk pondrejk mentioned this pull request Mar 18, 2024
Merged
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
@pondrejk @shweta83
eol banner (SatelliteQE#13211)
e862c66
pondrejk added a commit to pondrejk/robottelo that referenced this pull request Oct 22, 2024
@pondrejk
eol banner (SatelliteQE#13211)
561842a
@pondrejk pondrejk mentioned this pull request Oct 22, 2024
Merged
pondrejk added a commit to pondrejk/robottelo that referenced this pull request Oct 24, 2024
@pondrejk
eol banner (SatelliteQE#13211)
85c0352
pondrejk added a commit that referenced this pull request Oct 24, 2024
@pondrejk
[6.13.z] eol banner (#16729)
a519134 
eol banner (#13211)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pondrejk pondrejk

Labels
No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pondrejk @lhellebr @Satellite-QE