eol version check #13253

pondrejk · 2023-12-04T14:35:52Z

Problem Statement

This supplements tests for the EOL banner feature. The eol date for the version is defined in the satellite-lifecycle package (so that there is the same solution for connected and disconnected sats). This test aims to check the date in the package is correctly updated.

Solution

Comparing the date from the package with the date from the lifecycle api.

Keeping in draft state, as the EOL banner just got to 6.15, but not yet to older releases and the lifecycle api contains data only for released versions

Related Issues

satellite-jenkins MR 1185

lhellebr

Conceptually LGTM

lhellebr · 2023-12-04T15:51:19Z

tests/foreman/api/test_eol_banner.py

+    if result.status_code != 200:
+        raise requests.HTTPError(f'{settings.subscription.lifecycle_api_url} is not accessible')
+    versions = result.json()['data'][0]['versions']
+    version = [v for v in versions if v['name'] == current_version]


Suggested change

version = [v for v in versions if v['name'] == current_version]

version = [v for v in versions if v['name'] == current_version][0]

lhellebr · 2023-12-04T15:51:33Z

tests/foreman/api/test_eol_banner.py

+    version = [v for v in versions if v['name'] == current_version]
+    api_date = [
+        (p['date_format'], p['date'])
+        for p in version[0]['phases']


Suggested change

for p in version[0]['phases']

for p in version['phases']

lhellebr · 2023-12-04T15:57:24Z

tests/foreman/api/test_eol_banner.py

+        (p['date_format'], p['date'])
+        for p in version[0]['phases']
+        if p['name'] == 'Maintenance support'
+    ]


Suggested change

]

][0]

lhellebr · 2023-12-04T15:57:38Z

tests/foreman/api/test_eol_banner.py

+        for p in version[0]['phases']
+        if p['name'] == 'Maintenance support'
+    ]
+    if api_date[0][0] == 'string':


Suggested change

if api_date[0][0] == 'string':

if api_date[0] == 'string':

lhellebr · 2023-12-04T15:57:47Z

tests/foreman/api/test_eol_banner.py

+    ]
+    if api_date[0][0] == 'string':
+        assert eol_datetime.strftime("%B, %Y") in api_date[0][1]
+    if api_date[0][0] == 'date':


Suggested change

if api_date[0][0] == 'date':

if api_date[0] == 'date':

lhellebr · 2023-12-04T16:03:21Z

tests/foreman/api/test_eol_banner.py

+    """
+    current_version = '.'.join(target_sat.version.split('.')[0:2])
+    output = yaml.load(target_sat.execute(rf'cat {LIFECYCLE_METADATA_FILE}').stdout, yaml.Loader)
+    eol_datetime = datetime.strptime(output['releases'][current_version]['end_of_life'], '%Y-%m-%y')


Suggested change

eol_datetime = datetime.strptime(output['releases'][current_version]['end_of_life'], '%Y-%m-%y')

eol_datetime = datetime.strptime(output['releases'][current_version]['end_of_life'], '%Y-%m-%d')

lhellebr · 2023-12-04T16:06:56Z

tests/foreman/api/test_eol_banner.py

+        if p['name'] == 'Maintenance support'
+    ]
+    if api_date[0][0] == 'string':
+        assert eol_datetime.strftime("%B, %Y") in api_date[0][1]


Why is the comparison only accurate to a month?

Can't we test for equality?

github-actions · 2024-01-19T05:34:57Z

This pull request has not been updated in the past 45 days.

omkarkhatavkar · 2024-01-19T06:58:00Z

@pondrejk can you please work on the review comments as the PR is getting stale status

github-actions · 2024-03-05T05:35:51Z

This pull request has not been updated in the past 45 days.

github-actions · 2024-04-26T05:35:58Z

This pull request has not been updated in the past 45 days.

github-actions · 2024-05-04T05:34:30Z

This pull request is now being closed after stale warnings.

pondrejk · 2024-05-09T13:49:17Z

@lhellebr & reviewers, thanks for the patience, I applied the feedback. This PR requires satelliteqe-jenkins mr !1335 to be in. I'm assuming that released sat versions will be present in the lifecycle api, which might be considered naive, but I didn't find a sure way to establish which versions are published just from our configs, hope this makes sense

pondrejk · 2024-05-13T07:17:14Z

trigger: test-robottelo
pytest: tests/foreman/api/test_eol_banner.py

Satellite-QE · 2024-05-13T07:38:23Z

PRT Result

Build Number: 6900
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_eol_banner.py --external-logging
Test Result : ================== 1 passed, 9 warnings in 623.95s (0:10:23) ===================

rplevka

I believe there are some serious flaws in the assertion logic that might lead to false-negative test results in some scenarios.

rplevka · 2024-05-16T20:25:16Z

tests/foreman/api/test_eol_banner.py

+    if result.status_code != 200:
+        raise requests.HTTPError(f'{settings.subscription.lifecycle_api_url} is not accessible')


Suggested change

if result.status_code != 200:

raise requests.HTTPError(f'{settings.subscription.lifecycle_api_url} is not accessible')

result.raise_for_status()

https://docs.python-requests.org/en/latest/api/#requests.Response.raise_for_status

tests/foreman/api/test_eol_banner.py

pondrejk · 2024-05-20T13:02:52Z

trigger: test-robottelo
pytest: tests/foreman/api/test_eol_banner.py

rplevka

One more unhandled else

tests/foreman/api/test_eol_banner.py

pondrejk · 2024-05-29T08:04:14Z

hello @rplevka @lhellebr mind revisiting?

pnovotny

LGTM

(cherry picked from commit e65bda0)

eol version check (#13253)

pondrejk added 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Dec 4, 2023

pondrejk self-assigned this Dec 4, 2023

pondrejk requested review from a team as code owners December 4, 2023 14:35

pondrejk marked this pull request as draft December 4, 2023 14:36

lhellebr reviewed Dec 4, 2023

View reviewed changes

github-actions bot added the Stale Stale issue or Pull Request label Jan 19, 2024

github-actions bot removed the Stale Stale issue or Pull Request label Jan 20, 2024

github-actions bot added the Stale Stale issue or Pull Request label Mar 5, 2024

pondrejk removed the Stale Stale issue or Pull Request label Mar 11, 2024

github-actions bot added the Stale Stale issue or Pull Request label Apr 26, 2024

github-actions bot closed this May 4, 2024

pondrejk reopened this May 7, 2024

pondrejk removed the Stale Stale issue or Pull Request label May 7, 2024

pondrejk force-pushed the eol-version-check branch from c4aa858 to 2c08a8e Compare May 7, 2024 14:44

pondrejk removed 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 labels May 7, 2024

pondrejk force-pushed the eol-version-check branch from 2c08a8e to 4bc63f9 Compare May 9, 2024 13:38

pondrejk marked this pull request as ready for review May 9, 2024 13:38

pondrejk force-pushed the eol-version-check branch from 4bc63f9 to 06693a4 Compare May 9, 2024 13:39

pondrejk added CherryPick PR needs CherryPick to previous branches 6.14.z Introduced in or relating directly to Satellite 6.14 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing labels May 9, 2024

pondrejk force-pushed the eol-version-check branch from 06693a4 to 7bb97a2 Compare May 9, 2024 15:52

Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label May 13, 2024

rplevka requested changes May 16, 2024

View reviewed changes

pondrejk force-pushed the eol-version-check branch from 7bb97a2 to f0bb466 Compare May 20, 2024 11:56

Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label May 20, 2024

rplevka requested changes May 22, 2024

View reviewed changes

tests/foreman/api/test_eol_banner.py Outdated Show resolved Hide resolved

eol version check

f49f106

pondrejk force-pushed the eol-version-check branch from f0bb466 to f49f106 Compare May 27, 2024 09:59

lhellebr approved these changes May 29, 2024

View reviewed changes

rplevka approved these changes May 31, 2024

View reviewed changes

pnovotny approved these changes May 31, 2024

View reviewed changes

pondrejk merged commit e65bda0 into SatelliteQE:master Jun 3, 2024
8 checks passed

github-actions bot pushed a commit that referenced this pull request Jun 3, 2024

eol version check (#13253)

122b1cf

(cherry picked from commit e65bda0)

Satellite-QE mentioned this pull request Jun 3, 2024

[6.14.z] eol version check #15266

Merged

github-actions bot pushed a commit that referenced this pull request Jun 3, 2024

eol version check (#13253)

b4f994b

(cherry picked from commit e65bda0)

Satellite-QE mentioned this pull request Jun 3, 2024

[6.15.z] eol version check #15267

Merged

jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024

eol version check (SatelliteQE#13253)

09ce8bd

pondrejk added a commit to pondrejk/robottelo that referenced this pull request Oct 22, 2024

eol version check (SatelliteQE#13253)

1ac2ffa

pondrejk mentioned this pull request Oct 22, 2024

[6.13.z] eol version check (#13253) #16730

Merged

Gauravtalreja1 pushed a commit that referenced this pull request Oct 23, 2024

[6.13.z] eol version check (#13253) (#16730)

0bc9dbf

eol version check (#13253)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

eol version check #13253

eol version check #13253

pondrejk commented Dec 4, 2023

lhellebr left a comment

lhellebr Dec 4, 2023

lhellebr Dec 4, 2023

lhellebr Dec 4, 2023

lhellebr Dec 4, 2023

lhellebr Dec 4, 2023

lhellebr Dec 4, 2023

lhellebr Dec 4, 2023

github-actions bot commented Jan 19, 2024

omkarkhatavkar commented Jan 19, 2024

github-actions bot commented Mar 5, 2024

github-actions bot commented Apr 26, 2024

github-actions bot commented May 4, 2024

pondrejk commented May 9, 2024

pondrejk commented May 13, 2024

Satellite-QE commented May 13, 2024

rplevka left a comment

rplevka May 16, 2024

pondrejk commented May 20, 2024

rplevka left a comment

pondrejk commented May 29, 2024

pnovotny left a comment

	version = [v for v in versions if v['name'] == current_version]
	version = [v for v in versions if v['name'] == current_version][0]

	eol_datetime = datetime.strptime(output['releases'][current_version]['end_of_life'], '%Y-%m-%y')
	eol_datetime = datetime.strptime(output['releases'][current_version]['end_of_life'], '%Y-%m-%d')

		if result.status_code != 200:
		raise requests.HTTPError(f'{settings.subscription.lifecycle_api_url} is not accessible')

	if result.status_code != 200:
	raise requests.HTTPError(f'{settings.subscription.lifecycle_api_url} is not accessible')
	result.raise_for_status()

eol version check #13253

eol version check #13253

Conversation

pondrejk commented Dec 4, 2023

Problem Statement

Solution

Related Issues

lhellebr left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Jan 19, 2024

omkarkhatavkar commented Jan 19, 2024

github-actions bot commented Mar 5, 2024

github-actions bot commented Apr 26, 2024

github-actions bot commented May 4, 2024

pondrejk commented May 9, 2024

pondrejk commented May 13, 2024

Satellite-QE commented May 13, 2024

rplevka left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pondrejk commented May 20, 2024

rplevka left a comment

Choose a reason for hiding this comment

pondrejk commented May 29, 2024

pnovotny left a comment

Choose a reason for hiding this comment