Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update error message in negative settings test #13307

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Update error message in negative settings test #13307

merged 1 commit into from
Dec 7, 2023

Conversation

Gauravtalreja1
Copy link
Collaborator

Problem Statement

After #12796, we identified a failure for this negative tests, where validation error message for foreman_url setting has changed

Solution

Updating validation error message for assertion, and removing unnecessary parametrization over entries_per_page

Related Issues

SatelliteQE/airgun#1064

@Gauravtalreja1 Gauravtalreja1 added Easy Fix :) Easiest Fix to review and quick merge request. CherryPick PR needs CherryPick to previous branches 6.12.z Introduced in or relating directly to Satellite 6.12 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Dec 7, 2023
@Gauravtalreja1 Gauravtalreja1 self-assigned this Dec 7, 2023
@Gauravtalreja1 Gauravtalreja1 requested a review from a team as a code owner December 7, 2023 07:08
@Gauravtalreja1
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_settings.py -k test_negative_validate_foreman_url_error_message
airgun: 1064

@jameerpathan111 jameerpathan111 merged commit 9af01c7 into SatelliteQE:master Dec 7, 2023
13 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 7, 2023
@Gauravtalreja1 @web-flow
Update error message in negative settings test (#13307)
1b2a2de 
Signed-off-by: Gaurav Talreja <[email protected]>
(cherry picked from commit 9af01c7)
github-actions bot pushed a commit that referenced this pull request Dec 7, 2023
@Gauravtalreja1 @web-flow
Update error message in negative settings test (#13307)
d541520 
Signed-off-by: Gaurav Talreja <[email protected]>
(cherry picked from commit 9af01c7)
This was referenced Dec 7, 2023
Merged
Merged
github-actions bot pushed a commit that referenced this pull request Dec 7, 2023
@Gauravtalreja1 @web-flow
Update error message in negative settings test (#13307)
5b50b93 
Signed-off-by: Gaurav Talreja <[email protected]>
(cherry picked from commit 9af01c7)
@Satellite-QE Satellite-QE mentioned this pull request Dec 7, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Dec 7, 2023
@Gauravtalreja1 @web-flow
Update error message in negative settings test (#13307)
139f932 
Signed-off-by: Gaurav Talreja <[email protected]>
(cherry picked from commit 9af01c7)
@Satellite-QE Satellite-QE mentioned this pull request Dec 7, 2023
Merged
@Gauravtalreja1 Gauravtalreja1 deleted the fix-err-msg-settings branch December 7, 2023 09:24
Gauravtalreja1 added a commit that referenced this pull request Dec 7, 2023
@Gauravtalreja1
Update error message in negative settings test (#13307)
48a90ae 
Signed-off-by: Gaurav Talreja <[email protected]>
(cherry picked from commit 9af01c7)
Gauravtalreja1 added a commit that referenced this pull request Dec 7, 2023
@Gauravtalreja1
Update error message in negative settings test (#13307)
ccf74b2 
Signed-off-by: Gaurav Talreja <[email protected]>
(cherry picked from commit 9af01c7)
Gauravtalreja1 added a commit that referenced this pull request Dec 7, 2023
@Satellite-QE @Gauravtalreja1
[6.13.z] Update error message in negative settings test (#13310)
d50d86e 
Update error message in negative settings test (#13307)

Signed-off-by: Gaurav Talreja <[email protected]>
(cherry picked from commit 9af01c7)

Co-authored-by: Gaurav Talreja <[email protected]>
Gauravtalreja1 added a commit that referenced this pull request Dec 7, 2023
@Satellite-QE @Gauravtalreja1
[6.12.z] Update error message in negative settings test (#13309)
807e8bb 
Update error message in negative settings test (#13307)

Signed-off-by: Gaurav Talreja <[email protected]>
(cherry picked from commit 9af01c7)

Co-authored-by: Gaurav Talreja <[email protected]>
damoore044 pushed a commit to damoore044/robottelo that referenced this pull request Dec 11, 2023
@Gauravtalreja1 @damoore044
Update error message in negative settings test (SatelliteQE#13307)
9500b49 
Signed-off-by: Gaurav Talreja <[email protected]>
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
@Gauravtalreja1 @shweta83
Update error message in negative settings test (SatelliteQE#13307)
5404b3f 
Signed-off-by: Gaurav Talreja <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LadislavVasina1 LadislavVasina1 LadislavVasina1 approved these changes

@jameerpathan111 jameerpathan111 jameerpathan111 approved these changes

Assignees

@Gauravtalreja1 Gauravtalreja1

Labels
6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches Easy Fix :) Easiest Fix to review and quick merge request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gauravtalreja1 @jameerpathan111 @LadislavVasina1